Revert of [ObjC ARC] Converts ios/chrome/app to ARC.

Revert of [ObjC ARC] Converts ios/chrome/app to ARC. (patchset #1 id:1 of https://codereview.chromium.org/2449063002/ )

Reason for revert:
This CL closed the tree. The following is a partial log from the dump.

---
[1265/3927] OBJCXX obj/ios/chrome/browser/translate/translate/never_translate_infobar_controller.o
[1266/3927] OBJCXX obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
FAILED: obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o 
/b/build/slave/cache/cipd/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o.d -DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD -DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1 -DCR_XCODE_VERSION=0800 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG -DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen -fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector -fcolor-diagnostics -arch armv7 -Wall -Werror -Wextra -Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing -Wno-covered-switch-default -Wno-deprecated-register -Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override -Wno-shift-negative-value -Wno-undefined-var-template -Wno-nonportable-include-path -Wno-address-of-packed-member -O0 -gdwarf-2 -isysroot /Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.0.sdk -stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Xclang -load -Xclang ../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene -Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden -Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++11 -fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-rtti -fno-exceptions -c ../../ios/chrome/app/safe_mode_crashing_modules_config.mm -o obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
../../ios/chrome/app/safe_mode_crashing_modules_config.mm:12:2: error: "This file requires ARC support."
#error "This file requires ARC support."
 ^
1 error generated.
[1267/3927] CXX obj/components/browser_sync/browser_sync/profile_sync_service.o
ninja: build stopped: subcommand failed.

Original issue's description:
> [ObjC ARC] Converts ios/chrome/app to ARC.
> 
> Notable changes:none.
> 
> BUG=659150
> TEST=None.
> 
> Committed: https://crrev.com/7a1f218b33faf5d0dd637f6a6854566e6cd80a3d
> Cr-Commit-Position: refs/heads/master@{#427722}

TBR=eugenebut@chromium.org,thestig@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659150

[hongchan, 2016-10-26 17:31:28]

The CQ bit was checked by hongchan@chromium.org

[hongchan, 2016-10-26 17:31:29]

Created Revert of [ObjC ARC] Converts ios/chrome/app to ARC.

[commit-bot: I haz the power, 2016-10-26 17:32:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 17:33:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 17:33:10]

Failed to apply patch for ios/chrome/app/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: ios/chrome/app/BUILD.gn:23
  Falling back to three-way merge...
  Applied patch to 'ios/chrome/app/BUILD.gn' with conflicts.
  U ios/chrome/app/BUILD.gn

Patch:       ios/chrome/app/BUILD.gn
Index: ios/chrome/app/BUILD.gn
diff --git a/ios/chrome/app/BUILD.gn b/ios/chrome/app/BUILD.gn
index
f0c6649448c12b9e082980e1bb51407f32cbbc57..a94e27ff2e09c6cf0ccc71e257831387bac1056e
100644
--- a/ios/chrome/app/BUILD.gn
+++ b/ios/chrome/app/BUILD.gn
@@ -23,6 +23,4 @@
     "Foundation.framework",
     "UIKit.framework",
   ]
-
-  configs += [ "//build/config/compiler:enable_arc" ]
 }

[Eugene But (OOO till 7-30), 2016-10-26 17:34:47]

lgtm, it's interesting that landed CL has passed CQ :(

[Lei Zhang, 2016-10-26 17:34:57]

You are behind. It's already been reverted. Please coordinate via #chromium.

[hongchan, 2016-10-26 17:40:43]

Description was changed from

==========
Revert of [ObjC ARC] Converts ios/chrome/app to ARC. (patchset #1 id:1 of
https://codereview.chromium.org/2449063002/ )

Reason for revert:
This CL closed the tree. The following is a partial log from the dump.

---
[1265/3927] OBJCXX
obj/ios/chrome/browser/translate/translate/never_translate_infobar_controller.o
[1266/3927] OBJCXX obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
FAILED: obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o 
/b/build/slave/cache/cipd/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o.d
-DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1
-DCR_XCODE_VERSION=0800 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG
-DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
-fcolor-diagnostics -arch armv7 -Wall -Werror -Wextra
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-address-of-packed-member -O0 -gdwarf-2
-isysroot
/Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.0.sdk
-stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Xclang -load
-Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene
-Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden
-Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++11
-fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-rtti
-fno-exceptions -c ../../ios/chrome/app/safe_mode_crashing_modules_config.mm -o
obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
../../ios/chrome/app/safe_mode_crashing_modules_config.mm:12:2: error: "This
file requires ARC support."
#error "This file requires ARC support."
 ^
1 error generated.
[1267/3927] CXX obj/components/browser_sync/browser_sync/profile_sync_service.o
ninja: build stopped: subcommand failed.

Original issue's description:
> [ObjC ARC] Converts ios/chrome/app to ARC.
> 
> Notable changes:none.
> 
> BUG=659150
> TEST=None.
> 
> Committed: https://crrev.com/7a1f218b33faf5d0dd637f6a6854566e6cd80a3d
> Cr-Commit-Position: refs/heads/master@{#427722}

TBR=eugenebut@chromium.org,thestig@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659150
==========

to

==========
Revert of [ObjC ARC] Converts ios/chrome/app to ARC. (patchset #1 id:1 of
https://codereview.chromium.org/2449063002/ )

Reason for revert:
This CL closed the tree. The following is a partial log from the dump.

---
[1265/3927] OBJCXX
obj/ios/chrome/browser/translate/translate/never_translate_infobar_controller.o
[1266/3927] OBJCXX obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
FAILED: obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o 
/b/build/slave/cache/cipd/goma/gomacc
../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF
obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o.d
-DV8_DEPRECATION_WARNINGS -DNO_TCMALLOC -DDISABLE_NACL -DCHROMIUM_BUILD
-DFIELDTRIAL_TESTING_ENABLED -DCR_CLANG_REVISION=284979-1
-DCR_XCODE_VERSION=0800 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_DEBUG
-DDYNAMIC_ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -I../.. -Igen
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
-fcolor-diagnostics -arch armv7 -Wall -Werror -Wextra
-Wno-missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-covered-switch-default -Wno-deprecated-register
-Wno-unneeded-internal-declaration -Wno-inconsistent-missing-override
-Wno-shift-negative-value -Wno-undefined-var-template
-Wno-nonportable-include-path -Wno-address-of-packed-member -O0 -gdwarf-2
-isysroot
/Applications/Xcode8.0.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS10.0.sdk
-stdlib=libc++ -miphoneos-version-min=9.0 -fvisibility=hidden -Xclang -load
-Xclang
../../third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib
-Xclang -add-plugin -Xclang find-bad-constructs -Wheader-hygiene
-Wstring-conversion -fno-threadsafe-statics -fvisibility-inlines-hidden
-Wno-undefined-bool-conversion -Wno-tautological-undefined-compare -std=c++11
-fobjc-call-cxx-cdtors -Wobjc-missing-property-synthesis -fno-rtti
-fno-exceptions -c ../../ios/chrome/app/safe_mode_crashing_modules_config.mm -o
obj/ios/chrome/app/app/safe_mode_crashing_modules_config.o
../../ios/chrome/app/safe_mode_crashing_modules_config.mm:12:2: error: "This
file requires ARC support."
#error "This file requires ARC support."
 ^
1 error generated.
[1267/3927] CXX obj/components/browser_sync/browser_sync/profile_sync_service.o
ninja: build stopped: subcommand failed.

Original issue's description:
> [ObjC ARC] Converts ios/chrome/app to ARC.
> 
> Notable changes:none.
> 
> BUG=659150
> TEST=None.
> 
> Committed: https://crrev.com/7a1f218b33faf5d0dd637f6a6854566e6cd80a3d
> Cr-Commit-Position: refs/heads/master@{#427722}

TBR=eugenebut@chromium.org,thestig@chromium.org,stkhapugin@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=659150
==========