Avoid some FX_BOOL/bool noise in fx_codec_fax.cpp

Avoid some FX_BOOL/bool noise in fx_codec_fax.cpp

NEXTBIT() is particularly pernicious in that it isn't syntactically
an expression, but rather two expressions.  Replace it with an inline
along the way.

Committed: https://pdfium.googlesource.com/pdfium/+/1842be87408b06bf0b4c521044c09452caac5c80

[Tom Sepez, 2016-10-26 16:24:30]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 16:24:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-26 16:25:09]

Description was changed from

==========
Avoid some FX_BOOL/bool noise in fx_codec_fax.cpp

NEXTBIT() is particularly pernicious in that it isn't syntactically
an expression, but rather two expressions.  Replace it with an inline
along the way.
==========

to

==========
Avoid some FX_BOOL/bool noise in fx_codec_fax.cpp

NEXTBIT() is particularly pernicious in that it isn't syntactically
an expression, but rather two expressions.  Replace it with an inline
along the way.
==========

[Tom Sepez, 2016-10-26 16:25:10]

tsepez@chromium.org changed reviewers:
+ npm@chromium.org, weili@chromium.org

[Tom Sepez, 2016-10-26 16:25:56]

npm, see
https://build.chromium.org/p/tryserver.client.pdfium/builders/win_xfa/builds/...
for context on how this blocks fx_bool conversion.

[Tom Sepez, 2016-10-26 16:31:44]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 16:31:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 17:08:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 17:08:29]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-10-26 17:11:01]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 17:11:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom Sepez, 2016-10-26 17:15:58]

The CQ bit was checked by tsepez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 17:16:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[npm, 2016-10-26 17:17:58]

lgtm. You could also change the FX_BOOL to bool right away.
Not sure how long we'll keep having FX_BOOL as int for.

[Tom Sepez, 2016-10-26 17:27:51]

On 2016/10/26 17:17:58, npm wrote:
> lgtm. You could also change the FX_BOOL to bool right away.
> Not sure how long we'll keep having FX_BOOL as int for.

Acknowledged.  There are ~7K lines containing FX_BOOL, I'd assumed they'd get
flipped via sed rather than one at a time by hand once we tidy the underlying
mismatches.  We were stymied on this for a while due to silent breakage when we
flipped these; but the win_xfa bot has compilation flags to spot most of these
now ...

[Tom Sepez, 2016-10-26 17:28:01]

The CQ bit was unchecked by tsepez@chromium.org

[Tom Sepez, 2016-10-26 17:28:07]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2016-10-26 17:28:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 17:50:53]

Description was changed from

==========
Avoid some FX_BOOL/bool noise in fx_codec_fax.cpp

NEXTBIT() is particularly pernicious in that it isn't syntactically
an expression, but rather two expressions.  Replace it with an inline
along the way.
==========

to

==========
Avoid some FX_BOOL/bool noise in fx_codec_fax.cpp

NEXTBIT() is particularly pernicious in that it isn't syntactically
an expression, but rather two expressions.  Replace it with an inline
along the way.

Committed:
https://pdfium.googlesource.com/pdfium/+/1842be87408b06bf0b4c521044c09452caac...
==========

[commit-bot: I haz the power, 2016-10-26 17:50:54]

Committed patchset #4 (id:60001) as
https://pdfium.googlesource.com/pdfium/+/1842be87408b06bf0b4c521044c09452caac...