Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py

Issue 2452113002: rebaseline-cl: trigger all try jobs in one invocation of git cl try. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
index 03267c4e376e540782b4d1f51e53c097fa9884ac..5157098706bc81e1772549eb0df47dc824ba6787 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl.py
@@ -132,14 +132,11 @@ class RebaselineCL(AbstractParallelRebaselineCommand):
if builders_without_builds:
_log.info('Triggering try jobs for:')
+ command = ['try']
for builder in sorted(builders_without_builds):
_log.info(' %s', builder)
- # If the builders may be under different masters, then they cannot
- # all be started in one invocation of git cl try without providing
- # master names. Doing separate invocations is slower, but always works
- # even when there are builders under different master names.
- for builder in sorted(builders_without_builds):
- self.git_cl().run(['try', '-b', builder])
+ command.extend(['-b', builder])
+ self.git_cl().run(command)
return bool(builders_with_pending_builds or builders_without_builds)
« no previous file with comments | « no previous file | third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline_cl_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698