third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl - Issue 2452073002: Freeze global prototype chain per WebIDL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

Issue 2452073002: Freeze global prototype chain per WebIDL (Closed)

Patch Set: Test improvements Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8TestIntegerIndexedGlobal.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

index 65e9821eb4a4042be246a8cbd92eac330fc93899..f8b3952901da30e110d302fd7aeac1c0fc8fa4e9 100644

--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp.tmpl

@@ -317,6 +317,14 @@ static void install{{v8_class}}Template(v8::Isolate* isolate, const DOMWrapperWo

{%- if interface_name == 'Window' and not is_partial %}{{newline}}

prototypeTemplate->SetInternalFieldCount(V8Window::internalFieldCount);

{% endif %}

+ {% if is_immutable_prototype %}{{newline}}

+ // Global object prototype chain consists of Immutable Prototype Exotic Objects

+ prototypeTemplate->SetImmutableProto();

+ {% endif %}

+ {% if is_global %}{{newline}}

+ // Global objects are Immutable Prototype Exotic Objects

+ instanceTemplate->SetImmutableProto();

+ {% endif %}

// Register DOM constants, attributes and operations.

{% filter runtime_enabled(runtime_enabled_function) %}