Condition the libsecret use on chrome desktop builds to 'use_glib'

Condition the libsecret use on chrome desktop builds to 'use_glib'

Right now, libsecret files are added to the desktop linux
chrome builds conditioned by 'use_ozone'.

Although it works, 'use_ozone' is not the most accurate
variable to check for libsecret inclusion. A more accurate
check is 'use_glib', since GLib is the hard dependency
libsecret relies on.

Today use_ozone happens to work because it forcibly disables
use_glib.

BUG=295089
Committed: https://crrev.com/c1ce090fb362ed48b243cf3c5a926238abac36b5
Cr-Commit-Position: refs/heads/master@{#427801}

[tonikitoo, 2016-10-26 14:51:18]

Description was changed from

==========
Condition libsecret inclusion on the chrome build to 'use_glib'

Right now, libsecret dependency is added to the desktop linux
chrome build, conditioned by 'use_ozone'.

A more accurate check should use 'use_glib', since GLib is the
dependency libsecret relies on.

BUG=295089
==========

to

==========
Condition libsecret use on chrome desktop builds to 'use_glib'

Right now, the libsecret dependency is added to the desktop
linux chrome builds conditioned by 'use_ozone'.

A more accurate check would use 'use_glib' instead, since
GLib is the dependency libsecret relies on.

BUG=295089
==========

[tonikitoo, 2016-10-26 14:51:18]

tonikitoo@igalia.com changed reviewers:
+ rjkroege@chromium.org, thestig@chromium.org

[tonikitoo, 2016-10-26 14:51:31]

PTAL

[not to use - tonikitoo, 2016-10-26 15:01:33]

The CQ bit was checked by tonikitoo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 15:01:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tonikitoo, 2016-10-26 15:32:18]

Description was changed from

==========
Condition libsecret use on chrome desktop builds to 'use_glib'

Right now, the libsecret dependency is added to the desktop
linux chrome builds conditioned by 'use_ozone'.

A more accurate check would use 'use_glib' instead, since
GLib is the dependency libsecret relies on.

BUG=295089
==========

to

==========
Condition the libsecret use on chrome desktop builds to 'use_glib'

Right now, libsecret files are added to the desktop linux
chrome builds conditioned by 'use_ozone'.

Although it works, 'use_ozone' is not the most accurate 
variable to check for libsecret inclusion. A more accurate 
check is 'use_glib', since GLib is the hard dependency 
libsecret relies on. 

Today use_ozone happens to work because it forcibly disables 
use_glib.

BUG=29508
==========

[tonikitoo, 2016-10-26 15:32:52]

tonikitoo@igalia.com changed reviewers:
+ thomasanderson@chromium.org
- tonikitoo@chromium.org

[fwang, 2016-10-26 15:43:35]

informal l g t m

[Lei Zhang, 2016-10-26 16:58:28]

thestig@chromium.org changed reviewers:
+ cfroussios@chromium.org

[Lei Zhang, 2016-10-26 16:58:28]

thestig@chromium.org changed reviewers:
+ cfroussios@chromium.org

[Lei Zhang, 2016-10-26 16:58:29]

The BUG= line doesn't look right.

[Lei Zhang, 2016-10-26 16:58:29]

The BUG= line doesn't look right.

[Lei Zhang, 2016-10-26 16:59:28]

Makes sense, +cfroussios to confirm.

Sorry about the now triple post.

[tonikitoo, 2016-10-26 16:59:44]

Description was changed from

==========
Condition the libsecret use on chrome desktop builds to 'use_glib'

Right now, libsecret files are added to the desktop linux
chrome builds conditioned by 'use_ozone'.

Although it works, 'use_ozone' is not the most accurate 
variable to check for libsecret inclusion. A more accurate 
check is 'use_glib', since GLib is the hard dependency 
libsecret relies on. 

Today use_ozone happens to work because it forcibly disables 
use_glib.

BUG=29508
==========

to

==========
Condition the libsecret use on chrome desktop builds to 'use_glib'

Right now, libsecret files are added to the desktop linux
chrome builds conditioned by 'use_ozone'.

Although it works, 'use_ozone' is not the most accurate 
variable to check for libsecret inclusion. A more accurate 
check is 'use_glib', since GLib is the hard dependency 
libsecret relies on. 

Today use_ozone happens to work because it forcibly disables 
use_glib.

BUG=295089
==========

[tonikitoo, 2016-10-26 17:00:04]

On 2016/10/26 16:58:29, Lei Zhang wrote:
> The BUG= line doesn't look right.

True, fixed.

[Lei Zhang, 2016-10-26 17:06:08]

lgtm

[tonikitoo, 2016-10-26 17:07:12]

The CQ bit was checked by tonikitoo@igalia.com

[commit-bot: I haz the power, 2016-10-26 17:07:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 17:18:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 17:18:38]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[Lei Zhang, 2016-10-26 17:20:55]

Tree is closed. Try again in a bit?

[rjkroege, 2016-10-26 18:51:00]

lgtm

[Lei Zhang, 2016-10-26 18:51:33]

The CQ bit was checked by thestig@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:52:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 21:23:03]

Description was changed from

==========
Condition the libsecret use on chrome desktop builds to 'use_glib'

Right now, libsecret files are added to the desktop linux
chrome builds conditioned by 'use_ozone'.

Although it works, 'use_ozone' is not the most accurate 
variable to check for libsecret inclusion. A more accurate 
check is 'use_glib', since GLib is the hard dependency 
libsecret relies on. 

Today use_ozone happens to work because it forcibly disables 
use_glib.

BUG=295089
==========

to

==========
Condition the libsecret use on chrome desktop builds to 'use_glib'

Right now, libsecret files are added to the desktop linux
chrome builds conditioned by 'use_ozone'.

Although it works, 'use_ozone' is not the most accurate 
variable to check for libsecret inclusion. A more accurate 
check is 'use_glib', since GLib is the hard dependency 
libsecret relies on. 

Today use_ozone happens to work because it forcibly disables 
use_glib.

BUG=295089
==========

[commit-bot: I haz the power, 2016-10-26 21:23:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 21:25:50]

Description was changed from

==========
Condition the libsecret use on chrome desktop builds to 'use_glib'

Right now, libsecret files are added to the desktop linux
chrome builds conditioned by 'use_ozone'.

Although it works, 'use_ozone' is not the most accurate 
variable to check for libsecret inclusion. A more accurate 
check is 'use_glib', since GLib is the hard dependency 
libsecret relies on. 

Today use_ozone happens to work because it forcibly disables 
use_glib.

BUG=295089
==========

to

==========
Condition the libsecret use on chrome desktop builds to 'use_glib'

Right now, libsecret files are added to the desktop linux
chrome builds conditioned by 'use_ozone'.

Although it works, 'use_ozone' is not the most accurate
variable to check for libsecret inclusion. A more accurate
check is 'use_glib', since GLib is the hard dependency
libsecret relies on.

Today use_ozone happens to work because it forcibly disables
use_glib.

BUG=295089

Committed: https://crrev.com/c1ce090fb362ed48b243cf3c5a926238abac36b5
Cr-Commit-Position: refs/heads/master@{#427801}
==========

[commit-bot: I haz the power, 2016-10-26 21:25:51]

Patchset 2 (id:??) landed as
https://crrev.com/c1ce090fb362ed48b243cf3c5a926238abac36b5
Cr-Commit-Position: refs/heads/master@{#427801}

[fwang, 2016-10-28 07:15:23]

fwang@igalia.com changed reviewers:
+ fwang@igalia.com