Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tools/callstats.html

Issue 2452013002: [tools] Filter out accidental group entries in callstats.html (Closed)
Patch Set: fixing typo Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/callstats.html
diff --git a/tools/callstats.html b/tools/callstats.html
index cb2e0bea3e31adf49f15941f826cf30657c83c02..b70d40c98ae4e94bd062547fc1f0a490b5b998a9 100644
--- a/tools/callstats.html
+++ b/tools/callstats.html
@@ -1381,6 +1381,8 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
this.version = version;
}
add(entry) {
+ // Ignore accidentally added Group entries.
+ if (entry.name.startsWith(GroupedEntry.prefix)) return;
entry.page = this;
this.entryDict.set(entry.name, entry);
var added = false;
@@ -1559,7 +1561,7 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
/StackGuard|.*Optimize.*|.*Deoptimize.*|Recompile.*/, "#DC3912"));
Group.add('compile', new Group('Compile', /.*Compile.*/, "#FFAA00"));
Group.add('parse', new Group('Parse', /.*Parse.*/, "#FF6600"));
- Group.add('callback', new Group('Callback', /.*Callback$/, "#109618"));
+ Group.add('callback', new Group('Callback', /.*Callback.*/, "#109618"));
Group.add('api', new Group('API', /.*API.*/, "#990099"));
Group.add('gc', new Group('GC', /GC|AllocateInTargetSpace/, "#0099C6"));
Group.add('javascript', new Group('JavaScript', /JS_Execution/, "#DD4477"));
@@ -1568,7 +1570,7 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
class GroupedEntry extends Entry {
constructor(group) {
- super(0, 'Group-' + group.name, 0, 0, 0, 0, 0, 0);
+ super(0, GroupedEntry.prefix + group.name, 0, 0, 0, 0, 0, 0);
this.group = group;
this.entries = [];
}
@@ -1636,6 +1638,7 @@ code is governed by a BSD-style license that can be found in the LICENSE file.
return this.getVarianceForProperty('time')
}
}
+ GroupedEntry.prefix = 'Group-';
class UnclassifiedEntry extends GroupedEntry {
constructor(page) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698