Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issue 2452013002: [tools] Filter out accidental group entries in callstats.html (Closed)

Created:
4 years, 1 month ago by Camillo Bruni
Modified:
4 years, 1 month ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[tools] Filter out accidental group entries in callstats.html R=jochen@chromium.org NOTRY=true BUG= Committed: https://crrev.com/126e030e1dcf98d09045fa01b63356b90b627dff Cr-Commit-Position: refs/heads/master@{#40587}

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixing typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M tools/callstats.html View 1 4 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Camillo Bruni
PTAL
4 years, 1 month ago (2016-10-26 07:56:30 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/2452013002/diff/1/tools/callstats.html File tools/callstats.html (right): https://codereview.chromium.org/2452013002/diff/1/tools/callstats.html#newcode1384 tools/callstats.html:1384: // Ignore accidentally added Gruop entries. Group
4 years, 1 month ago (2016-10-26 08:05:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2452013002/20001
4 years, 1 month ago (2016-10-26 12:18:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 12:20:10 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:13:51 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/126e030e1dcf98d09045fa01b63356b90b627dff
Cr-Commit-Position: refs/heads/master@{#40587}

Powered by Google App Engine
This is Rietveld 408576698