Convert editing/deleting/remove-formatting.html to utilize w3c test harness

Convert editing/deleting/remove-formatting.html to utilize w3c test harness

This patch converts "remove-formatting.html" to utilize w3c test harness with
|assert_selection()| to simplify test case for improving code health.

This patch is a preparation of http://crrev.com/1958093002

BUG=625533
TEST=n/a; no behavior changes

Committed: https://crrev.com/8d1fbfc272fe547c7206d5c8c1538bcdbcb7507f
Cr-Commit-Position: refs/heads/master@{#427663}

[yosin_UTC9, 2016-10-26 06:41:42]

Description was changed from

==========
2016-10-26T15:40:38

BUG=
==========

to

==========
Convert editing/deleting/remove-formatting.html to utilize w3c test harness

This patch converts "remove-formatting.html" to utilize w3c test harness with
|assert_selection()| to simplify test case for improving code health.

This patch is a preparation of http://crrev.com/1958093002

BUG=625533
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2016-10-26 06:41:46]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 06:42:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-26 07:28:27]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2016-10-26 07:28:28]

PTAL

[commit-bot: I haz the power, 2016-10-26 07:45:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 07:45:56]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-26 07:56:34]

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html
(right):

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html:9:
assert_false(selection.document.execCommand('removeFormat'),
I think using queryCommandEnabled is better here.

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html:22:
'RemoveFormat command with caret');
I don't understand this test. The title and the assertion failure messages are
inconsistent.

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html:30:
'<table><tbody><tr><td>one</td><td>two</td></tr></tbody></table>',
There's a <br> before <table> in the original test

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html:32:
'<span style="text-decoration:line-through">baz|</span>',
There is some plain text between <u> and <span> in the original test.

There is also a <br> after span.

End tag </div> is missing.

[yosin_UTC9, 2016-10-26 08:14:26]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 08:14:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2016-10-26 08:16:39]

PTAL

Update to follow comments.

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html
(right):

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html:9:
assert_false(selection.document.execCommand('removeFormat'),
On 2016/10/26 at 07:56:34, Xiaocheng wrote:
> I think using queryCommandEnabled is better here.

This verifies return value of Document#execCommand().

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html:22:
'RemoveFormat command with caret');
On 2016/10/26 at 07:56:34, Xiaocheng wrote:
> I don't understand this test. The title and the assertion failure messages are
inconsistent.

Oops, I forgot to set caret.

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html:30:
'<table><tbody><tr><td>one</td><td>two</td></tr></tbody></table>',
On 2016/10/26 at 07:56:34, Xiaocheng wrote:
> There's a <br> before <table> in the original test

<br> doesn't affect test. Anyway, I add <br> before <table>.

https://codereview.chromium.org/2452003002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/editing/execCommand/remove-formatting.html:32:
'<span style="text-decoration:line-through">baz|</span>',
On 2016/10/26 at 07:56:34, Xiaocheng wrote:
> There is some plain text between <u> and <span> in the original test.
> There is also a <br> after span.
I think it isn't significant. Anyway, I added.

 
> End tag </div> is missing.
Good catch!

[Xiaocheng, 2016-10-26 08:54:28]

lgtm

[yosin_UTC9, 2016-10-26 08:58:02]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2016-10-26 08:58:05]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2016-10-26 08:58:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 10:45:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-26 10:47:35]

Description was changed from

==========
Convert editing/deleting/remove-formatting.html to utilize w3c test harness

This patch converts "remove-formatting.html" to utilize w3c test harness with
|assert_selection()| to simplify test case for improving code health.

This patch is a preparation of http://crrev.com/1958093002

BUG=625533
TEST=n/a; no behavior changes
==========

to

==========
Convert editing/deleting/remove-formatting.html to utilize w3c test harness

This patch converts "remove-formatting.html" to utilize w3c test harness with
|assert_selection()| to simplify test case for improving code health.

This patch is a preparation of http://crrev.com/1958093002

BUG=625533
TEST=n/a; no behavior changes

Committed: https://crrev.com/8d1fbfc272fe547c7206d5c8c1538bcdbcb7507f
Cr-Commit-Position: refs/heads/master@{#427663}
==========

[commit-bot: I haz the power, 2016-10-26 10:47:36]

Patchset 2 (id:??) landed as
https://crrev.com/8d1fbfc272fe547c7206d5c8c1538bcdbcb7507f
Cr-Commit-Position: refs/heads/master@{#427663}