Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(286)

Issue 2451983002: Convert editing/deleting/merge-into-empty-block-[12].html to utilize w3c test harness (Closed)

Created:
4 years, 1 month ago by yosin_UTC9
Modified:
4 years, 1 month ago
Reviewers:
yoichio, Xiaocheng
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert editing/deleting/merge-into-empty-block-[12].html to utilize w3c test harness This patch converts "merge-into-empty-block-[12].html" to utilize w3c test harness with |assert_selection()| to simplify test case and consolidate into "merge_into_block.html" since these test files uses similar sample for improving code health. This patch is a preparation of http://crrev.com/1958093002 BUG=625533 TEST=n/a; no behavior chagnes Committed: https://crrev.com/704b6ce74f9e2d5316c27ffb3f7b29c151c4be43 Cr-Commit-Position: refs/heads/master@{#427630}

Patch Set 1 : 2016-10-26T14:01:59 #

Messages

Total messages: 14 (9 generated)
yosin_UTC9
PTAL
4 years, 1 month ago (2016-10-26 06:07:42 UTC) #7
Xiaocheng
lgtm
4 years, 1 month ago (2016-10-26 07:38:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451983002/1
4 years, 1 month ago (2016-10-26 07:41:30 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 07:46:49 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 07:48:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/704b6ce74f9e2d5316c27ffb3f7b29c151c4be43
Cr-Commit-Position: refs/heads/master@{#427630}

Powered by Google App Engine
This is Rietveld 408576698