Fix and simplify _File creation.

Fix and simplify _File creation.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/3d730e3735f75df4c49450e27befc8c59fd400df

[scheglov, 2016-10-26 01:34:24]

Description was changed from

==========
Fix and simplify _File creation.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Fix and simplify _File creation.

TBR

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/3d730e3735f75df4c49450e27befc8c59fd400df
==========

[scheglov, 2016-10-26 01:34:25]

Committed patchset #1 (id:1) manually as
3d730e3735f75df4c49450e27befc8c59fd400df (presubmit successful).

[Brian Wilkerson, 2016-10-26 06:56:59]

lgtm

[Paul Berry, 2016-10-31 16:30:25]

lgtm

https://codereview.chromium.org/2451973002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2451973002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:530: // _File.forResolution()
also updates the content hash in the cache.
Nit: it might be clearer to say "_fileForPath() also updates the content
hash...", since the connection to _File.forResolution is not obvious at this
point in the code.

https://codereview.chromium.org/2451973002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:539: hasMismatch = true;
Can you add a comment explaining why it's not ok to `break;` here?

(I'm guessing that for some reason it's necessary to call _fileForPath() to
ensure that all of the new file contents get read, but I'm not sure why that
would be needed.)

[scheglov, 2016-10-31 17:49:07]

https://codereview.chromium.org/2451973002/diff/1/pkg/analyzer/lib/src/dart/a...
File pkg/analyzer/lib/src/dart/analysis/driver.dart (right):

https://codereview.chromium.org/2451973002/diff/1/pkg/analyzer/lib/src/dart/a...
pkg/analyzer/lib/src/dart/analysis/driver.dart:539: hasMismatch = true;
On 2016/10/31 16:30:25, Paul Berry wrote:
> Can you add a comment explaining why it's not ok to `break;` here?
> 
> (I'm guessing that for some reason it's necessary to call _fileForPath() to
> ensure that all of the new file contents get read, but I'm not sure why that
> would be needed.)

The code was restructured that the "break" does not happen anyway.
But the idea is that we need to re-read and check for API signatures of all
files.
If we break after the first, we fail to re-read other files.