|
|
Created:
4 years, 1 month ago by Sam McNally Modified:
4 years, 1 month ago Reviewers:
Ken Rockot(use gerrit already) CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, fuzzing_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionChange most IPC tests to use ChannelMojo.
Most IPC::Channels in production are now ChannelMojo, but most tests
use the platform-specific Channel implementations. This changes the IPC
tests other than IPCMultiSendingFdsTest.StressTest and those in
ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use
ChannelMojo.
BUG=659448
Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9
Committed: https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1
Cr-Original-Commit-Position: refs/heads/master@{#427624}
Cr-Commit-Position: refs/heads/master@{#427988}
Patch Set 1 : #Patch Set 2 : #
Messages
Total messages: 71 (62 generated)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #1 (id:1) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Port higher-level IPC tests to use ChannelMojo. BUG=659448 ========== to ========== Change most IPC tests to use ChannelMojo. BUG=659448 ==========
Description was changed from ========== Change most IPC tests to use ChannelMojo. BUG=659448 ========== to ========== Change most IPC tests to use ChannelMojo. BUG=659448 ==========
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Change most IPC tests to use ChannelMojo. BUG=659448 ========== to ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 ==========
Description was changed from ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 ========== to ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
sammc@chromium.org changed reviewers: + rockot@chromium.org
lgtm
The CQ bit was checked by sammc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #1 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 ========== to ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Cr-Commit-Position: refs/heads/master@{#427624} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Cr-Commit-Position: refs/heads/master@{#427624}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:100001) has been created in https://codereview.chromium.org/2455583002/ by foolip@chromium.org. The reason for reverting is: IPCChannelBadMessageTest.BadMessage is failing on Ubuntu-12.04. .
Message was sent while issue was closed.
Description was changed from ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Cr-Commit-Position: refs/heads/master@{#427624} ========== to ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Cr-Commit-Position: refs/heads/master@{#427624} ==========
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:120001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by sammc@chromium.org to run a CQ dry run
Patchset #3 (id:160001) has been deleted
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Patchset #2 (id:140001) has been deleted
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by sammc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org Link to the patchset: https://codereview.chromium.org/2451953003/#ps180001 (title: " ")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Cr-Commit-Position: refs/heads/master@{#427624} ========== to ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Cr-Commit-Position: refs/heads/master@{#427624} ==========
Message was sent while issue was closed.
Committed patchset #2 (id:180001)
Message was sent while issue was closed.
Description was changed from ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Cr-Commit-Position: refs/heads/master@{#427624} ========== to ========== Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Committed: https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1 Cr-Original-Commit-Position: refs/heads/master@{#427624} Cr-Commit-Position: refs/heads/master@{#427988} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1 Cr-Commit-Position: refs/heads/master@{#427988} |