Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2451953003: Change most IPC tests to use ChannelMojo. (Closed)

Created:
4 years, 1 month ago by Sam McNally
Modified:
4 years, 1 month ago
CC:
Aaron Boodman, abarth-chromium, chrome-apps-syd-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, fuzzing_chromium.org, jam, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change most IPC tests to use ChannelMojo. Most IPC::Channels in production are now ChannelMojo, but most tests use the platform-specific Channel implementations. This changes the IPC tests other than IPCMultiSendingFdsTest.StressTest and those in ipc_channel_unittest.cc and ipc_channel_posix_unittest.cc to use ChannelMojo. BUG=659448 Committed: https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Committed: https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1 Cr-Original-Commit-Position: refs/heads/master@{#427624} Cr-Commit-Position: refs/heads/master@{#427988}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -488 lines) Patch
M ipc/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/DEPS View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_channel_mojo_unittest.cc View 32 chunks +41 lines, -131 lines 0 comments Download
M ipc/ipc_channel_proxy_unittest.cc View 1 6 chunks +18 lines, -25 lines 0 comments Download
M ipc/ipc_fuzzing_tests.cc View 1 6 chunks +7 lines, -18 lines 0 comments Download
M ipc/ipc_send_fds_test.cc View 3 chunks +29 lines, -32 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 61 chunks +273 lines, -270 lines 0 comments Download
M ipc/ipc_test_base.h View 2 chunks +84 lines, -0 lines 0 comments Download
M ipc/ipc_test_base.cc View 2 chunks +58 lines, -0 lines 0 comments Download
M ipc/sync_socket_unittest.cc View 2 chunks +5 lines, -11 lines 0 comments Download

Messages

Total messages: 71 (62 generated)
Sam McNally
4 years, 1 month ago (2016-10-26 06:54:52 UTC) #37
Ken Rockot(use gerrit already)
lgtm
4 years, 1 month ago (2016-10-26 07:10:49 UTC) #38
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451953003/100001
4 years, 1 month ago (2016-10-26 07:12:24 UTC) #40
commit-bot: I haz the power
Committed patchset #1 (id:100001)
4 years, 1 month ago (2016-10-26 07:16:09 UTC) #41
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d45a95a8ac88b71b768a850cbeffc2c318a10cf9 Cr-Commit-Position: refs/heads/master@{#427624}
4 years, 1 month ago (2016-10-26 07:17:56 UTC) #43
foolip
A revert of this CL (patchset #1 id:100001) has been created in https://codereview.chromium.org/2455583002/ by foolip@chromium.org. ...
4 years, 1 month ago (2016-10-26 08:56:40 UTC) #44
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451953003/180001
4 years, 1 month ago (2016-10-27 10:09:46 UTC) #67
commit-bot: I haz the power
Committed patchset #2 (id:180001)
4 years, 1 month ago (2016-10-27 10:14:27 UTC) #69
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 10:16:26 UTC) #71
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4bcc4ed62e7c10652053462cee1016ff1d7b8cb1
Cr-Commit-Position: refs/heads/master@{#427988}

Powered by Google App Engine
This is Rietveld 408576698