Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2451943002: Remove runtime flag 'UnsafeES3APIs' from blink webgl (Closed)

Created:
4 years, 1 month ago by yunchao
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews, haraken, Kai Ninomiya, Peter Beverloo, Yang Gu
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove runtime flag 'UnsafeES3APIs' from blink webgl. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. Command line option "--enable-unsafe-es3-apis" would be unnecessary and removed afterwards. Intent to implement: https://www.chromestatus.com/features/6694359164518400 Launch bug: http://crbug.com/641635 (Note that this is not the launch CL -- it's still not possible to create a WebGL 2.0 context without the flag) BUG=654787, 641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/58dd74648c572ceaf28175b2a2802d3c50a9b316 Cr-Commit-Position: refs/heads/master@{#428253}

Patch Set 1 #

Patch Set 2 : Remove runtime flag 'UnsafeES3APIs' in Blink WebGL #

Patch Set 3 : dispatch event when webgl2 context creation failure #

Patch Set 4 : update layout test expectation (webexposed/global-interface-listing) #

Patch Set 5 : update layout test expectation for global-interface-listing-expected.txt #

Total comments: 2

Patch Set 6 : Addressed kbr@'s feedback, and rebased the code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1623 lines, -25 lines) Patch
M content/child/runtime_features.cc View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/virtual/stable/webexposed/global-interface-listing-expected.txt View 1 2 3 4 4 chunks +808 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 3 4 4 chunks +810 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp View 1 2 3 4 5 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLQuery.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSampler.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLSync.idl View 1 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLTransformFeedback.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLVertexArrayObject.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebRuntimeFeatures.cpp View 1 2 3 4 5 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebRuntimeFeatures.h View 1 2 3 4 5 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 70 (49 generated)
yunchao
PTAL, Ken and Zhenyao.
4 years, 1 month ago (2016-10-26 03:28:10 UTC) #20
Zhenyao Mo
On 2016/10/26 03:28:10, yunchao wrote: > PTAL, Ken and Zhenyao. The failures look real
4 years, 1 month ago (2016-10-26 05:42:01 UTC) #27
yunchao
On 2016/10/26 05:42:01, Zhenyao Mo wrote: > On 2016/10/26 03:28:10, yunchao wrote: > > PTAL, ...
4 years, 1 month ago (2016-10-26 14:49:47 UTC) #34
yunchao
On 2016/10/26 14:49:47, yunchao wrote: > On 2016/10/26 05:42:01, Zhenyao Mo wrote: > > On ...
4 years, 1 month ago (2016-10-26 16:32:32 UTC) #40
Zhenyao Mo
On 2016/10/26 16:32:32, yunchao wrote: > On 2016/10/26 14:49:47, yunchao wrote: > > On 2016/10/26 ...
4 years, 1 month ago (2016-10-26 17:10:11 UTC) #41
Dirk Pranke
On 2016/10/26 16:32:32, yunchao wrote: > @dpranke, @peter, @abarth, @ojan, could you take a look ...
4 years, 1 month ago (2016-10-26 17:19:18 UTC) #42
Ken Russell (switch to Gerrit)
Thanks Yunchao for helping move this forward. LGTM. https://codereview.chromium.org/2451943002/diff/80001/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp (right): https://codereview.chromium.org/2451943002/diff/80001/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp#newcode46 third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp:46: "Fail ...
4 years, 1 month ago (2016-10-26 18:33:45 UTC) #45
Ken Russell (switch to Gerrit)
Let's save time by CQ'ing this now.
4 years, 1 month ago (2016-10-26 18:34:02 UTC) #46
Ken Russell (switch to Gerrit)
esprehn: could you review the content/child/ , Source/web/ and public/web/ changes?
4 years, 1 month ago (2016-10-26 18:38:02 UTC) #48
esprehn
This patch is actually shipping all those webgl2 interfaces to stable. Did you intend to ...
4 years, 1 month ago (2016-10-26 19:13:01 UTC) #50
Ken Russell (switch to Gerrit)
Added link to the intent to implement and launch bug. Note that this isn't launching ...
4 years, 1 month ago (2016-10-26 20:06:39 UTC) #52
esprehn
lgtm
4 years, 1 month ago (2016-10-26 20:24:03 UTC) #53
esprehn
Please make sure you have enough LGTMs and sent all the right emails before landing. ...
4 years, 1 month ago (2016-10-26 20:26:03 UTC) #54
esprehn
Please make sure you have enough LGTMs and sent all the right emails before landing. ...
4 years, 1 month ago (2016-10-26 20:26:04 UTC) #55
Ken Russell (switch to Gerrit)
On 2016/10/26 20:24:03, esprehn wrote: > lgtm Per offline discussion with Elliott: we need to ...
4 years, 1 month ago (2016-10-26 20:26:32 UTC) #56
yunchao
On 2016/10/26 20:26:32, Ken Russell wrote: > On 2016/10/26 20:24:03, esprehn wrote: > > lgtm ...
4 years, 1 month ago (2016-10-26 23:55:31 UTC) #57
yunchao
Thanks for your review, Ken and Zhenyao and all. Ken, Please help to merge this ...
4 years, 1 month ago (2016-10-27 14:53:14 UTC) #60
Ken Russell (switch to Gerrit)
On 2016/10/27 14:53:14, yunchao wrote: > Thanks for your review, Ken and Zhenyao and all. ...
4 years, 1 month ago (2016-10-28 01:34:02 UTC) #63
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451943002/100001
4 years, 1 month ago (2016-10-28 01:34:42 UTC) #66
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 1 month ago (2016-10-28 02:23:45 UTC) #68
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:27:27 UTC) #70
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/58dd74648c572ceaf28175b2a2802d3c50a9b316
Cr-Commit-Position: refs/heads/master@{#428253}

Powered by Google App Engine
This is Rietveld 408576698