|
|
Chromium Code Reviews
DescriptionRemove runtime flag 'UnsafeES3APIs' from blink webgl.
This is the first step to remove unsafe mode and enable
ES3 APIs for WebGL2 and ES3 context by default.
Command line option "--enable-unsafe-es3-apis" would be
unnecessary and removed afterwards.
Intent to implement:
https://www.chromestatus.com/features/6694359164518400
Launch bug:
http://crbug.com/641635
(Note that this is not the launch CL -- it's still not possible to create a WebGL 2.0 context without the flag)
BUG=654787, 641635
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
Committed: https://crrev.com/58dd74648c572ceaf28175b2a2802d3c50a9b316
Cr-Commit-Position: refs/heads/master@{#428253}
Patch Set 1 #Patch Set 2 : Remove runtime flag 'UnsafeES3APIs' in Blink WebGL #Patch Set 3 : dispatch event when webgl2 context creation failure #Patch Set 4 : update layout test expectation (webexposed/global-interface-listing) #Patch Set 5 : update layout test expectation for global-interface-listing-expected.txt #
Total comments: 2
Patch Set 6 : Addressed kbr@'s feedback, and rebased the code #Messages
Total messages: 70 (49 generated)
Description was changed from ========== Remove unsafe mode from blink webgl only BUG= ========== to ========== Remove unsafe mode from blink webgl only BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...) cast_shell_android on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...) linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...) win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...) win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...) win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...) win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove unsafe mode from blink webgl only BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Remove unsafe mode from blink webgl only BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
yunchao.he@intel.com changed reviewers: + kbr@chromium.org, qiankun.miao@intel.com, zmo@chromium.org
Description was changed from ========== Remove unsafe mode from blink webgl only BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Remove runtime flag 'UnsafeES3APIs' from blink weblg2. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Description was changed from ========== Remove runtime flag 'UnsafeES3APIs' from blink weblg2. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Remove runtime flag 'UnsafeES3APIs' from blink webgl. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. Command line option "--enable-unsafe-es3-apis" would be unnecessary and removed afterwards. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
PTAL, Ken and Zhenyao.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
On 2016/10/26 03:28:10, yunchao wrote: > PTAL, Ken and Zhenyao. The failures look real
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/10/26 05:42:01, Zhenyao Mo wrote: > On 2016/10/26 03:28:10, yunchao wrote: > > PTAL, Ken and Zhenyao. > > The failures look real Ah... We removed the UnsafeES3APIs runtime flag and expose interfaces for WebGL2 by default, we should update the layout test expectation for global-interface-listing.html. I suppose the failure will gone after patch set 4. BTW, the layout test seems to be broken in my local Linux. The failure says that content_shell(used by layout test) is timeout when loading. I have tried on my Linux desktop and Qiankun's linux desktop. Maybe we can file a bug for this if it fails on more linux machines (But it is OK on bots... weird...).
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
yunchao.he@intel.com changed reviewers: + abarth@chromium.org, dpranke@google.com, ojan@chromium.org, peter@chromium.org
yunchao.he@intel.com changed reviewers: + esprehn@chromium.org
yunchao.he@intel.com changed reviewers: + dglazkov@chromium.org, jochen@chromium.org, pdr@chromium.org
On 2016/10/26 14:49:47, yunchao wrote: > On 2016/10/26 05:42:01, Zhenyao Mo wrote: > > On 2016/10/26 03:28:10, yunchao wrote: > > > PTAL, Ken and Zhenyao. > > > > The failures look real > > Ah... We removed the UnsafeES3APIs runtime flag and expose interfaces for WebGL2 > by default, we should update the layout test expectation for > global-interface-listing.html. I suppose the failure will gone after patch set > 4. > > BTW, the layout test seems to be broken in my local Linux. The failure says that > content_shell(used by layout test) is timeout when loading. I have tried on my > Linux desktop and Qiankun's linux desktop. Maybe we can file a bug for this if > it fails on more linux machines (But it is OK on bots... weird...). I think it is OK now, the layout test expectation in global-interface-listing-expected.txt should be alphabetical. Zhenyao and Ken, could you take a look for the whole patch? @pdr, @dglazkov, @jochen, could you take a look at the Blink public/ part, and blink web/ and platform/? @dpranke, @peter, @abarth, @ojan, could you take a look at the Layout test? @esprehn, could you take a look at the content/child/? Thanks a lot!
On 2016/10/26 16:32:32, yunchao wrote: > On 2016/10/26 14:49:47, yunchao wrote: > > On 2016/10/26 05:42:01, Zhenyao Mo wrote: > > > On 2016/10/26 03:28:10, yunchao wrote: > > > > PTAL, Ken and Zhenyao. > > > > > > The failures look real > > > > Ah... We removed the UnsafeES3APIs runtime flag and expose interfaces for > WebGL2 > > by default, we should update the layout test expectation for > > global-interface-listing.html. I suppose the failure will gone after patch set > > 4. > > > > BTW, the layout test seems to be broken in my local Linux. The failure says > that > > content_shell(used by layout test) is timeout when loading. I have tried on my > > Linux desktop and Qiankun's linux desktop. Maybe we can file a bug for this if > > it fails on more linux machines (But it is OK on bots... weird...). > > I think it is OK now, the layout test expectation in > global-interface-listing-expected.txt should be alphabetical. > Zhenyao and Ken, could you take a look for the whole patch? > @pdr, @dglazkov, @jochen, could you take a look at the Blink public/ part, and > blink web/ and platform/? > @dpranke, @peter, @abarth, @ojan, could you take a look at the Layout test? > @esprehn, could you take a look at the content/child/? > > Thanks a lot! lgtm Thanks Yunchao
On 2016/10/26 16:32:32, yunchao wrote: > @dpranke, @peter, @abarth, @ojan, could you take a look at the Layout test? Anyone can review changes to LayoutTests/*, so you don't need our review specifically. I defer to zmo here, so lgtm :).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Thanks Yunchao for helping move this forward. LGTM. https://codereview.chromium.org/2451943002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp (right): https://codereview.chromium.org/2451943002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp:46: "Fail to create a WebGL2 context.")); Fail -> Failed
Let's save time by CQ'ing this now.
kbr@chromium.org changed reviewers: - abarth@chromium.org, dglazkov@chromium.org, jochen@chromium.org, ojan@chromium.org, pdr@chromium.org, peter@chromium.org
esprehn: could you review the content/child/ , Source/web/ and public/web/ changes?
esprehn@chromium.org changed reviewers: + dpranke@chromium.org
This patch is actually shipping all those webgl2 interfaces to stable. Did you intend to do that?
Description was changed from ========== Remove runtime flag 'UnsafeES3APIs' from blink webgl. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. Command line option "--enable-unsafe-es3-apis" would be unnecessary and removed afterwards. BUG=654787 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Remove runtime flag 'UnsafeES3APIs' from blink webgl. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. Command line option "--enable-unsafe-es3-apis" would be unnecessary and removed afterwards. Intent to implement: https://www.chromestatus.com/features/6694359164518400 Launch bug: http://crbug.com/641635 (Note that this is not the launch CL -- it's still not possible to create a WebGL 2.0 context without the flag) BUG=654787, 641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Added link to the intent to implement and launch bug. Note that this isn't launching the feature yet -- just taking off the runtime flag for the interfaces.
lgtm
Please make sure you have enough LGTMs and sent all the right emails before landing. Note that shipping interfaces even if you can't create them also comes with risk and requires the same process. :) -- You received this message because you are subscribed to the Google Groups "Blink Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to blink-reviews+unsubscribe@chromium.org.
Please make sure you have enough LGTMs and sent all the right emails before landing. Note that shipping interfaces even if you can't create them also comes with risk and requires the same process. :) -- You received this message because you are subscribed to the Google Groups "Chromium-reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to chromium-reviews+unsubscribe@chromium.org.
On 2016/10/26 20:24:03, esprehn wrote: > lgtm Per offline discussion with Elliott: we need to send the implement to ship to blink-dev, and get LGTMx3 there, before landing this. zmo@ and I will work on this and send it today.
On 2016/10/26 20:26:32, Ken Russell wrote: > On 2016/10/26 20:24:03, esprehn wrote: > > lgtm > > Per offline discussion with Elliott: we need to send the implement to ship to > blink-dev, and get LGTMx3 there, before landing this. zmo@ and I will work on > this and send it today. Got it. Thanks for your effort, Ken and Zhenyao.
The CQ bit was checked by yunchao.he@intel.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Thanks for your review, Ken and Zhenyao and all. Ken, Please help to merge this one if we get LGTMx3 from blink-dev for [Intent to Ship WebGL 2.0]. https://codereview.chromium.org/2451943002/diff/80001/third_party/WebKit/Sour... File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp (right): https://codereview.chromium.org/2451943002/diff/80001/third_party/WebKit/Sour... third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp:46: "Fail to create a WebGL2 context.")); On 2016/10/26 18:33:44, Ken Russell wrote: > Fail -> Failed Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
On 2016/10/27 14:53:14, yunchao wrote: > Thanks for your review, Ken and Zhenyao and all. > Ken, Please help to merge this one if we get LGTMx3 from blink-dev for [Intent > to Ship WebGL 2.0]. > > https://codereview.chromium.org/2451943002/diff/80001/third_party/WebKit/Sour... > File third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp (right): > > https://codereview.chromium.org/2451943002/diff/80001/third_party/WebKit/Sour... > third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp:46: "Fail to > create a WebGL2 context.")); > On 2016/10/26 18:33:44, Ken Russell wrote: > > Fail -> Failed > > Done. LGTMx3 received on blink-dev! Landing! Thank you!
The CQ bit was checked by kbr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org, kbr@chromium.org, esprehn@chromium.org, zmo@chromium.org Link to the patchset: https://codereview.chromium.org/2451943002/#ps100001 (title: "Addressed kbr@'s feedback, and rebased the code")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove runtime flag 'UnsafeES3APIs' from blink webgl. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. Command line option "--enable-unsafe-es3-apis" would be unnecessary and removed afterwards. Intent to implement: https://www.chromestatus.com/features/6694359164518400 Launch bug: http://crbug.com/641635 (Note that this is not the launch CL -- it's still not possible to create a WebGL 2.0 context without the flag) BUG=654787, 641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Remove runtime flag 'UnsafeES3APIs' from blink webgl. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. Command line option "--enable-unsafe-es3-apis" would be unnecessary and removed afterwards. Intent to implement: https://www.chromestatus.com/features/6694359164518400 Launch bug: http://crbug.com/641635 (Note that this is not the launch CL -- it's still not possible to create a WebGL 2.0 context without the flag) BUG=654787, 641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ==========
Message was sent while issue was closed.
Committed patchset #6 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Remove runtime flag 'UnsafeES3APIs' from blink webgl. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. Command line option "--enable-unsafe-es3-apis" would be unnecessary and removed afterwards. Intent to implement: https://www.chromestatus.com/features/6694359164518400 Launch bug: http://crbug.com/641635 (Note that this is not the launch CL -- it's still not possible to create a WebGL 2.0 context without the flag) BUG=654787, 641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel ========== to ========== Remove runtime flag 'UnsafeES3APIs' from blink webgl. This is the first step to remove unsafe mode and enable ES3 APIs for WebGL2 and ES3 context by default. Command line option "--enable-unsafe-es3-apis" would be unnecessary and removed afterwards. Intent to implement: https://www.chromestatus.com/features/6694359164518400 Launch bug: http://crbug.com/641635 (Note that this is not the launch CL -- it's still not possible to create a WebGL 2.0 context without the flag) BUG=654787, 641635 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/58dd74648c572ceaf28175b2a2802d3c50a9b316 Cr-Commit-Position: refs/heads/master@{#428253} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/58dd74648c572ceaf28175b2a2802d3c50a9b316 Cr-Commit-Position: refs/heads/master@{#428253} |
