OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
9 """ | 9 """ |
10 | 10 |
(...skipping 290 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
301 ), | 301 ), |
302 ( | 302 ( |
303 '#pragma comment(lib,', | 303 '#pragma comment(lib,', |
304 ( | 304 ( |
305 'Specify libraries to link with in build files and not in the source.', | 305 'Specify libraries to link with in build files and not in the source.', |
306 ), | 306 ), |
307 True, | 307 True, |
308 (), | 308 (), |
309 ), | 309 ), |
310 ( | 310 ( |
311 r'FOR_EACH_OBSERVER(', | |
312 ( | |
313 'Use range-based for loops to iterate through base::ObserverList, e.g.', | |
314 ' for (auto& observer : observers) { observer.Observe(); }', | |
315 ), | |
316 True, | |
317 (), | |
318 ), | |
319 ( | |
320 r'STLDeleteContainerPointers', # http://crbug.com/555865 | 311 r'STLDeleteContainerPointers', # http://crbug.com/555865 |
321 ( | 312 ( |
322 'This call is obsolete with C++ 11; create a container with owning', | 313 'This call is obsolete with C++ 11; create a container with owning', |
323 'pointers instead (e.g. std::vector<std::unique_ptr<x>> ).', | 314 'pointers instead (e.g. std::vector<std::unique_ptr<x>> ).', |
324 ), | 315 ), |
325 True, | 316 True, |
326 (), | 317 (), |
327 ), | 318 ), |
328 ( | 319 ( |
329 r'STLDeleteElements', # http://crbug.com/555865 | 320 r'STLDeleteElements', # http://crbug.com/555865 |
(...skipping 1970 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
2300 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 2291 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
2301 input_api, | 2292 input_api, |
2302 output_api, | 2293 output_api, |
2303 json_url='http://chromium-status.appspot.com/current?format=json')) | 2294 json_url='http://chromium-status.appspot.com/current?format=json')) |
2304 | 2295 |
2305 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2296 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
2306 input_api, output_api)) | 2297 input_api, output_api)) |
2307 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2298 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
2308 input_api, output_api)) | 2299 input_api, output_api)) |
2309 return results | 2300 return results |
OLD | NEW |