Add serialization/deserialization for FakePictureLayer for testing.

Add serialization/deserialization for FakePictureLayer for testing.

Previously we serialize/deserialize FakePictureLayer into PictureLayer.
This introduced an issue in LayerTreeHostTestReadyToActivateNonEmpty and
other unit test cases in layer_tree_host_unittests.cc that downcasting
from PictureLayerImpl to FakePictureLayerImpl will fail.

The data flow was:
FakePictureLayer==>PictureLayer==>PictureLayerImpl==>
FakePictureLayerImpl(downcast failure).

This CL adds procedure to process FakePictureLayer, so it can be
deserialized and down cast correctly.

The data flow becomes:
FakePictureLayer==>FakePictureLayer==>FakePictureLayerImpl

BUG=657871
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/b67229217f5b54fad888c74f6528be4af51e5a6e
Cr-Commit-Position: refs/heads/master@{#427886}

[xingliu, 2016-10-25 21:41:20]

Description was changed from

==========
Add serialization/deserialization for FakePictureLayer for testing.

Previously we serialize/deserialize FakePictureLayer into PictureLayer.
This introduced an issue in LayerTreeHostTestReadyToActivateNonEmpty and
other unit test cases in layer_tree_host_unittests.cc.

The data flow was:
FakePictureLayer==>PictureLayer==>PictureLayerImpl==>
FakePictureLayerImpl(downcast failure).

This CL adds procedure to process FakePictureLayer, so it can be
deserialized and down cast correctly.

The data flow becomes:
FakePictureLayer==>FakePictureLayer==>FakePictureLayerImpl


BUG=657871
==========

to

==========
Add serialization/deserialization for FakePictureLayer for testing.

Previously we serialize/deserialize FakePictureLayer into PictureLayer.
This introduced an issue in LayerTreeHostTestReadyToActivateNonEmpty and
other unit test cases in layer_tree_host_unittests.cc.

The data flow was:
FakePictureLayer==>PictureLayer==>PictureLayerImpl==>
FakePictureLayerImpl(downcast failure).

This CL adds procedure to process FakePictureLayer, so it can be
deserialized and down cast correctly.

The data flow becomes:
FakePictureLayer==>FakePictureLayer==>FakePictureLayerImpl


BUG=657871
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[xingliu, 2016-10-25 21:44:58]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 21:45:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-25 22:05:46]

Description was changed from

==========
Add serialization/deserialization for FakePictureLayer for testing.

Previously we serialize/deserialize FakePictureLayer into PictureLayer.
This introduced an issue in LayerTreeHostTestReadyToActivateNonEmpty and
other unit test cases in layer_tree_host_unittests.cc.

The data flow was:
FakePictureLayer==>PictureLayer==>PictureLayerImpl==>
FakePictureLayerImpl(downcast failure).

This CL adds procedure to process FakePictureLayer, so it can be
deserialized and down cast correctly.

The data flow becomes:
FakePictureLayer==>FakePictureLayer==>FakePictureLayerImpl


BUG=657871
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Add serialization/deserialization for FakePictureLayer for testing.

Previously we serialize/deserialize FakePictureLayer into PictureLayer.
This introduced an issue in LayerTreeHostTestReadyToActivateNonEmpty and
other unit test cases in layer_tree_host_unittests.cc that downcasting
from PictureLayerImpl to FakePictureLayerImpl will fail.

The data flow was:
FakePictureLayer==>PictureLayer==>PictureLayerImpl==>
FakePictureLayerImpl(downcast failure).

This CL adds procedure to process FakePictureLayer, so it can be
deserialized and down cast correctly.

The data flow becomes:
FakePictureLayer==>FakePictureLayer==>FakePictureLayerImpl


BUG=657871
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

[xingliu, 2016-10-25 22:14:28]

xingliu@chromium.org changed reviewers:
+ dtrainor@chromium.org, khushalsagar@chromium.org

[xingliu, 2016-10-25 22:14:29]

Please help take a look, process the FakePictureLayer in testing code.

[commit-bot: I haz the power, 2016-10-25 22:49:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-25 22:49:03]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-10-25 23:53:06]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-25 23:53:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 01:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 01:04:25]

Dry run: This issue passed the CQ dry run.

[Khushal, 2016-10-26 01:08:02]

khushalsagar@chromium.org changed reviewers:
+ ajuma@chromium.org

[Khushal, 2016-10-26 01:08:03]

lgtm.

+ajuma for cc review.

https://codereview.chromium.org/2451913002/diff/20001/cc/test/fake_picture_la...
File cc/test/fake_picture_layer.h (left):

https://codereview.chromium.org/2451913002/diff/20001/cc/test/fake_picture_la...
cc/test/fake_picture_layer.h:49: DisplayItemList* display_list() const {
Thanks for the cleanup. :)

https://codereview.chromium.org/2451913002/diff/20001/cc/test/fake_picture_la...
File cc/test/fake_picture_layer.h (right):

https://codereview.chromium.org/2451913002/diff/20001/cc/test/fake_picture_la...
cc/test/fake_picture_layer.h:38: bool Update() override;
Would be great if you could put the Layer overrides in one block too.

// Layer interface.
CreateLayerImpl();
Update();
...

and then the rest of the methods.

[David Trainor- moved to gerrit, 2016-10-26 01:39:51]

Thanks!  This looks good.

[David Trainor- moved to gerrit, 2016-10-26 01:42:28]

lgtm

[ajuma, 2016-10-26 12:56:22]

lgtm

[xingliu, 2016-10-26 17:10:11]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 17:10:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-26 17:56:41]

Grouped up overrides in fake picture layer header. About to commit this CL to
CQ.

https://codereview.chromium.org/2451913002/diff/20001/cc/test/fake_picture_la...
File cc/test/fake_picture_layer.h (right):

https://codereview.chromium.org/2451913002/diff/20001/cc/test/fake_picture_la...
cc/test/fake_picture_layer.h:38: bool Update() override;
On 2016/10/26 01:08:02, Khushal wrote:
> Would be great if you could put the Layer overrides in one block too.
> 
> // Layer interface.
> CreateLayerImpl();
> Update();
> ...
> 
> and then the rest of the methods.

Done.

[commit-bot: I haz the power, 2016-10-26 19:18:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 19:18:20]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-10-26 19:41:18]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-10-26 19:41:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, ajuma@chromium.org, khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2451913002/#ps40001
(title: "Group up overrides in fake_picture_layer.h")

[commit-bot: I haz the power, 2016-10-26 19:42:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Khushal, 2016-10-26 20:04:55]

https://codereview.chromium.org/2451913002/diff/40001/cc/test/fake_picture_la...
File cc/test/fake_picture_layer.h (right):

https://codereview.chromium.org/2451913002/diff/40001/cc/test/fake_picture_la...
cc/test/fake_picture_layer.h:51: void
SetTypeForProtoSerialization(proto::LayerNode* proto) const override;
nit: Shouldn't this be with the other Layer overrides?

[xingliu, 2016-10-26 20:06:00]

The CQ bit was unchecked by xingliu@chromium.org

[xingliu, 2016-10-26 20:10:20]

The CQ bit was checked by xingliu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 20:11:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-26 20:13:18]

https://codereview.chromium.org/2451913002/diff/40001/cc/test/fake_picture_la...
File cc/test/fake_picture_layer.h (right):

https://codereview.chromium.org/2451913002/diff/40001/cc/test/fake_picture_la...
cc/test/fake_picture_layer.h:51: void
SetTypeForProtoSerialization(proto::LayerNode* proto) const override;
On 2016/10/26 20:04:55, Khushal wrote:
> nit: Shouldn't this be with the other Layer overrides?

Done.
 
Sorry I missed this one.

[commit-bot: I haz the power, 2016-10-26 21:21:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:21:52]

Dry run: This issue passed the CQ dry run.

[xingliu, 2016-10-26 21:25:02]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-10-26 21:25:03]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, ajuma@chromium.org, khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2451913002/#ps60001
(title: "Group up another Layer override.")

[commit-bot: I haz the power, 2016-10-26 21:25:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xingliu, 2016-10-26 21:38:18]

The CQ bit was checked by xingliu@chromium.org

[xingliu, 2016-10-26 21:38:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org, ajuma@chromium.org, khushalsagar@chromium.org
Link to the patchset: https://codereview.chromium.org/2451913002/#ps100001
(title: "Revert change from another CL, that I cl patch this one to that one.")

[commit-bot: I haz the power, 2016-10-26 21:39:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 22:40:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:40:48]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[xingliu, 2016-10-26 22:44:59]

The CQ bit was checked by xingliu@chromium.org

[commit-bot: I haz the power, 2016-10-26 22:45:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 00:07:42]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-27 00:10:51]

Description was changed from

==========
Add serialization/deserialization for FakePictureLayer for testing.

Previously we serialize/deserialize FakePictureLayer into PictureLayer.
This introduced an issue in LayerTreeHostTestReadyToActivateNonEmpty and
other unit test cases in layer_tree_host_unittests.cc that downcasting
from PictureLayerImpl to FakePictureLayerImpl will fail.

The data flow was:
FakePictureLayer==>PictureLayer==>PictureLayerImpl==>
FakePictureLayerImpl(downcast failure).

This CL adds procedure to process FakePictureLayer, so it can be
deserialized and down cast correctly.

The data flow becomes:
FakePictureLayer==>FakePictureLayer==>FakePictureLayerImpl


BUG=657871
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
==========

to

==========
Add serialization/deserialization for FakePictureLayer for testing.

Previously we serialize/deserialize FakePictureLayer into PictureLayer.
This introduced an issue in LayerTreeHostTestReadyToActivateNonEmpty and
other unit test cases in layer_tree_host_unittests.cc that downcasting
from PictureLayerImpl to FakePictureLayerImpl will fail.

The data flow was:
FakePictureLayer==>PictureLayer==>PictureLayerImpl==>
FakePictureLayerImpl(downcast failure).

This CL adds procedure to process FakePictureLayer, so it can be
deserialized and down cast correctly.

The data flow becomes:
FakePictureLayer==>FakePictureLayer==>FakePictureLayerImpl

BUG=657871
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel

Committed: https://crrev.com/b67229217f5b54fad888c74f6528be4af51e5a6e
Cr-Commit-Position: refs/heads/master@{#427886}
==========

[commit-bot: I haz the power, 2016-10-27 00:10:52]

Patchset 6 (id:??) landed as
https://crrev.com/b67229217f5b54fad888c74f6528be4af51e5a6e
Cr-Commit-Position: refs/heads/master@{#427886}