Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2451893003: Move Document global rule data to CSSGlobalRuleSet. (Closed)

Created:
4 years, 1 month ago by rune
Modified:
4 years, 1 month ago
Reviewers:
meade_UTC10, esprehn
CC:
chromium-reviews, blink-reviews-style_chromium.org, blink-reviews-css, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move Document global rule data to CSSGlobalRuleSet. This CL is split out from [1] with some modifications. Instead of storing these data in the StyleResolver, create a new class to store them in StyleEngine instead. See the design document linked from issue 401359 which talks about moving this content off of StyleResolver. Also made a note that we should further try to contain as much of this data as possible per TreeScope to avoid the need for constantly having to update these meta data for shadow tree modifications. We get rid of some of the duplicate storing of some of these features. See what was previously set on StyleEngine (resetCSSFeatureFlags()). This is also in preparation for async stylesheet update (issue 567021). There are few places where we synchronously update this new rule set directly after marking it as dirty which will happen later when all parts of [1] lands. Another synchronous update we will be able to remove later is making the RuleFeatureSet up-to-date when scheduling style invalidations (marked as TODOs for sync calls to ensureResolver()). The need for these calls is supported by the added invalidation tests which would otherwise fail. [1] https://codereview.chromium.org/1913833002/ BUG=401359, 567021 Committed: https://crrev.com/17bc158897bb9b9d6b1400ed76092a412de16bc9 Cr-Commit-Position: refs/heads/master@{#428327}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+334 lines, -237 lines) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/class-invalidation-after-adding-sheet.html View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.h View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSDefaultStyleSheets.cpp View 1 2 chunks +4 lines, -3 lines 0 comments Download
A third_party/WebKit/Source/core/css/CSSGlobalRuleSet.h View 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/core/css/CSSGlobalRuleSet.cpp View 1 chunk +79 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.h View 5 chunks +1 line, -27 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 29 chunks +33 lines, -122 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Fullscreen.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.h View 1 8 chunks +30 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 1 20 chunks +99 lines, -62 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
rune
Ptal
4 years, 1 month ago (2016-10-26 15:02:14 UTC) #3
rune
4 years, 1 month ago (2016-10-26 17:40:06 UTC) #7
meade_UTC10
lgtm Nice CL! \o/
4 years, 1 month ago (2016-10-28 01:54:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451893003/1
4 years, 1 month ago (2016-10-28 07:00:26 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel_ng/builds/252274)
4 years, 1 month ago (2016-10-28 07:02:36 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451893003/20001
4 years, 1 month ago (2016-10-28 08:56:19 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 10:20:54 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 10:22:25 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/17bc158897bb9b9d6b1400ed76092a412de16bc9
Cr-Commit-Position: refs/heads/master@{#428327}

Powered by Google App Engine
This is Rietveld 408576698