Revert "Recognize and optimize a.runtimeType == b.runtimeType pattern."

Revert "Recognize and optimize a.runtimeType == b.runtimeType pattern."

This reverts commit f4ec20abac2286604565e9d5a6d1d744849c964d.

Revert "Use ZoneHandle when creating ConstantInstr"

This reverts commit cb87f2d82fc8b4dab02e994361e97ed13c9859b8.

This change introduced crashes on AOT and runtime errors on the GN SDK build.

TBR=vegorov@google.com

Committed: https://github.com/dart-lang/sdk/commit/890f694de5fecdda128851ded06ea40ecd3c6c07

[rmacnak, 2016-10-25 20:19:38]

Description was changed from

==========
Revert "Recognize and optimize a.runtimeType == b.runtimeType pattern."

This reverts commit f4ec20abac2286604565e9d5a6d1d744849c964d.

Revert "Use ZoneHandle when creating ConstantInstr"

This reverts commit cb87f2d82fc8b4dab02e994361e97ed13c9859b8.

This change introduced crashes on AOT and runtime errors on the GN SDK build.

TBR=vegorov@google.com
==========

to

==========
Revert "Recognize and optimize a.runtimeType == b.runtimeType pattern."

This reverts commit f4ec20abac2286604565e9d5a6d1d744849c964d.

Revert "Use ZoneHandle when creating ConstantInstr"

This reverts commit cb87f2d82fc8b4dab02e994361e97ed13c9859b8.

This change introduced crashes on AOT and runtime errors on the GN SDK build.

TBR=vegorov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/890f694de5fecdda128851ded06ea40ecd3c6c07
==========

[rmacnak, 2016-10-25 20:19:39]

Committed patchset #1 (id:1) manually as
890f694de5fecdda128851ded06ea40ecd3c6c07 (presubmit successful).

[Vyacheslav Egorov (Google), 2016-10-26 05:17:20]

Thanks! 

What do I run to reproduce runtime errors on the GN build?

I am actually using GN build to run my tests - have not seen any failures.

[Vyacheslav Egorov (Google), 2016-10-26 05:21:41]

I see red GN builder on FYI waterfall -but given that it did not go green after
revert I will conclude that this patch has nothing to do with redness.

[rmacnak, 2016-11-01 00:33:31]

On 2016/10/26 05:21:41, Vyacheslav Egorov (Google) wrote:
> I see red GN builder on FYI waterfall -but given that it did not go green
after
> revert I will conclude that this patch has nothing to do with redness.

Yes, it seems to have been a fluke.