Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2451883002:
Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image (Closed)
DescriptionRestrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image
TBR=yusufo@chromium.org
BUG=655970
Committed: https://crrev.com/ca6324d8474f7b2e23b21c78b7bf4e6f390757d6
Cr-Commit-Position: refs/heads/master@{#427899}
Patch Set 1 #
Messages
Total messages: 22 (14 generated)
The CQ bit was checked by wychen@chromium.org to run a CQ dry run
wychen@chromium.org changed reviewers: + ianwen@chromium.org, yusufo@chromium.org
PTAL
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image BUG=655970 ========== to ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image BUG=655970 ==========
wychen@chromium.org changed reviewers: + ianwen@chromium.org, yusufo@chromium.org
PTAL
lgtm. Thanks for the investigation.
Description was changed from ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image BUG=655970 ========== to ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image TBR=yusufo@chromium.org BUG=655970 ==========
wychen@chromium.org changed reviewers: - yusufo@chromium.org
The CQ bit was checked by wychen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image TBR=yusufo@chromium.org BUG=655970 ========== to ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image TBR=yusufo@chromium.org BUG=655970 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image TBR=yusufo@chromium.org BUG=655970 ========== to ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image TBR=yusufo@chromium.org BUG=655970 Committed: https://crrev.com/ca6324d8474f7b2e23b21c78b7bf4e6f390757d6 Cr-Commit-Position: refs/heads/master@{#427899} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/ca6324d8474f7b2e23b21c78b7bf4e6f390757d6 Cr-Commit-Position: refs/heads/master@{#427899}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2457693002/ by foolip@chromium.org. The reason for reverting is: Failures in chrome_public_test_apk on Android Tests (dbg) including failures in CustomTabActivityTest traced to this CL by findit..
Message was sent while issue was closed.
Description was changed from ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image TBR=yusufo@chromium.org BUG=655970 Committed: https://crrev.com/ca6324d8474f7b2e23b21c78b7bf4e6f390757d6 Cr-Commit-Position: refs/heads/master@{#427899} ========== to ========== Restrict flaky CustomTabActivityTest#testContextMenuEntriesForLink/Image TBR=yusufo@chromium.org BUG=655970 Committed: https://crrev.com/ca6324d8474f7b2e23b21c78b7bf4e6f390757d6 Cr-Commit-Position: refs/heads/master@{#427899} ==========
Message was sent while issue was closed.
wychen@chromium.org changed reviewers: + yusufo@chromium.org
Message was sent while issue was closed.
On 2016/10/27 08:56:36, foolip wrote: > A revert of this CL (patchset #1 id:1) has been created in > https://codereview.chromium.org/2457693002/ by mailto:foolip@chromium.org. > > The reason for reverting is: Failures in chrome_public_test_apk on Android Tests > (dbg) including > failures in CustomTabActivityTest traced to this CL by findit.. I think the result returned by findit was not accurate due to flaky tests. The build returned to normal before the revert. https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Test... I'll land it again as is and hopefully sticks this time. https://codereview.chromium.org/2454503006/ |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
