src/compiler/ia32/code-generator-ia32.cc - Issue 2451853002: Uniform and precise source positions for inlining

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/ia32/code-generator-ia32.cc

Issue 2451853002: Uniform and precise source positions for inlining (Closed)

Patch Set: addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler/ia32/code-generator-ia32.cc

diff --git a/src/compiler/ia32/code-generator-ia32.cc b/src/compiler/ia32/code-generator-ia32.cc

index 23ebac852476288aa0319b5b3658389f19c17302..20afdc104d0d28598596c03845eb4a4e89b8695b 100644

--- a/src/compiler/ia32/code-generator-ia32.cc

+++ b/src/compiler/ia32/code-generator-ia32.cc

@@ -1790,7 +1790,7 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleDeoptimizerCall(

if (deopt_entry == nullptr) return kTooManyDeoptimizationBailouts;

DeoptimizeReason deoptimization_reason =

GetDeoptimizationReason(deoptimization_id);

- __ RecordDeoptReason(deoptimization_reason, pos.raw(), deoptimization_id);

+ __ RecordDeoptReason(deoptimization_reason, pos, deoptimization_id);

__ call(deopt_entry, RelocInfo::RUNTIME_ENTRY);

return kSuccess;

}