src/perf-jit.cc - Issue 2451853002: Uniform and precise source positions for inlining

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/perf-jit.cc

Issue 2451853002: Uniform and precise source positions for inlining (Closed)

Patch Set: addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/perf-jit.cc

diff --git a/src/perf-jit.cc b/src/perf-jit.cc

index a8c7255396f6529e190a2d6c407c1728ccfb9f46..c6e23dc0986c756cd4e802570e9e991b215bfeb0 100644

--- a/src/perf-jit.cc

+++ b/src/perf-jit.cc

@@ -299,7 +299,7 @@ void PerfJitLogger::LogWriteDebugInfo(Code* code, SharedFunctionInfo* shared) {

for (SourcePositionTableIterator iterator(code->source_position_table());

!iterator.done(); iterator.Advance()) {

- int position = iterator.source_position();

+ int position = iterator.source_position().ScriptOffset();

int line_number = Script::GetLineNumber(script, position);

// Compute column.

int relative_line_number = line_number - script_line_offset;