src/crankshaft/mips/lithium-codegen-mips.cc - Issue 2451853002: Uniform and precise source positions for inlining

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/crankshaft/mips/lithium-codegen-mips.cc

Issue 2451853002: Uniform and precise source positions for inlining (Closed)

Patch Set: addressed comments Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/crankshaft/mips/lithium-codegen-mips.cc

diff --git a/src/crankshaft/mips/lithium-codegen-mips.cc b/src/crankshaft/mips/lithium-codegen-mips.cc

index 93801fa070a4a4c0d97d2045968a33e5c44a8f7e..589aa0a00fc68fda96799b1e5fc92dc4998bea42 100644

--- a/src/crankshaft/mips/lithium-codegen-mips.cc

+++ b/src/crankshaft/mips/lithium-codegen-mips.cc

@@ -267,8 +267,7 @@ bool LCodeGen::GenerateDeferredCode() {

HValue* value =

instructions_->at(code->instruction_index())->hydrogen_value();

- RecordAndWritePosition(

- chunk()->graph()->SourcePositionToScriptPosition(value->position()));

+ RecordAndWritePosition(value->position());

Comment(";;; <@%d,#%d> "

"-------------------- Deferred %s --------------------",