Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2425)

Unified Diff: src/assembler.cc

Issue 2451853002: Uniform and precise source positions for inlining (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/assembler.cc
diff --git a/src/assembler.cc b/src/assembler.cc
index 676a9febdbff695b79db82dadfa5a1958125d143..d41c13830776367cd80ab2e58cdd4f73bf332145 100644
--- a/src/assembler.cc
+++ b/src/assembler.cc
@@ -1891,11 +1891,12 @@ int ConstantPoolBuilder::Emit(Assembler* assm) {
// Platform specific but identical code for all the platforms.
-void Assembler::RecordDeoptReason(DeoptimizeReason reason, int raw_position,
- int id) {
+void Assembler::RecordDeoptReason(DeoptimizeReason reason,
+ SourcePosition position, int id) {
if (FLAG_trace_deopt || isolate()->is_profiling()) {
EnsureSpace ensure_space(this);
- RecordRelocInfo(RelocInfo::DEOPT_POSITION, raw_position);
+ RecordRelocInfo(RelocInfo::DEOPT_POSITION, position.ScriptOffset());
+ RecordRelocInfo(RelocInfo::DEOPT_POSITION, position.InliningId());
alph 2016/11/07 22:38:39 Hmm, looks hacky. How about adding a new tag for i
RecordRelocInfo(RelocInfo::DEOPT_REASON, static_cast<int>(reason));
RecordRelocInfo(RelocInfo::DEOPT_ID, id);
}
« no previous file with comments | « src/assembler.h ('k') | src/compilation-info.h » ('j') | src/compiler/ast-graph-builder.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698