Uniform and precise source positions for inlining

test/unittests/source-position-table-unittest.cc

Index: test/unittests/source-position-table-unittest.cc
diff --git a/test/unittests/source-position-table-unittest.cc b/test/unittests/source-position-table-unittest.cc
index 01d96750614fe1f86b91dff86f8aa44f0a30b815..e68319376618b38aa01059d4fc47dc0a6dad1524 100644
--- a/test/unittests/source-position-table-unittest.cc
+++ b/test/unittests/source-position-table-unittest.cc
@@ -23,10 +23,12 @@ static int offsets[] = {0,   1,   2,    3,    4,     30,      31,  32,
                         33,  62,  63,   64,   65,    126,     127, 128,
                         129, 250, 1000, 9999, 12000, 31415926};
 
+SourcePosition toPos(int offset) { return SourcePosition(offset); }

[Michael Starzinger, 2016/11/03 12:41:44]

nit: Should either be a member of SourcePositionTableTest or go inside an
anonymous namespace (I personally prefer the former).

[vogelheim, 2016/11/04 10:57:42]

I'm rather unhappy about this!

The point of these unit tests is to run the whole encoding/decoding machinery
through its paces. But all the SourcePositions you create here are highly
unusual, because the 2nd parameter is always the default. In other words,
encoding/decoding with inlining ids is 100% untested!!!

So... either extend the unit tests to have meaningful 'inline ids', not merely
default ones. or add new unittests with meaningful 'inline ids'.  

+
 TEST_F(SourcePositionTableTest, EncodeStatement) {
   SourcePositionTableBuilder builder(zone());
   for (int i = 0; i < arraysize(offsets); i++) {
-    builder.AddPosition(offsets[i], offsets[i], true);
+    builder.AddPosition(offsets[i], toPos(offsets[i]), true);
   }
 
   // To test correctness, we rely on the assertions in ToSourcePositionTable().
@@ -38,8 +40,8 @@ TEST_F(SourcePositionTableTest, EncodeStatement) {
 TEST_F(SourcePositionTableTest, EncodeStatementDuplicates) {
   SourcePositionTableBuilder builder(zone());
   for (int i = 0; i < arraysize(offsets); i++) {
-    builder.AddPosition(offsets[i], offsets[i], true);
-    builder.AddPosition(offsets[i], offsets[i] + 1, true);
+    builder.AddPosition(offsets[i], toPos(offsets[i]), true);
+    builder.AddPosition(offsets[i], toPos(offsets[i] + 1), true);
   }
 
   // To test correctness, we rely on the assertions in ToSourcePositionTable().
@@ -51,7 +53,7 @@ TEST_F(SourcePositionTableTest, EncodeStatementDuplicates) {
 TEST_F(SourcePositionTableTest, EncodeExpression) {
   SourcePositionTableBuilder builder(zone());
   for (int i = 0; i < arraysize(offsets); i++) {
-    builder.AddPosition(offsets[i], offsets[i], false);
+    builder.AddPosition(offsets[i], toPos(offsets[i]), false);
   }
   CHECK(!builder.ToSourcePositionTable(isolate(), Handle<AbstractCode>())
              .is_null());
@@ -66,9 +68,9 @@ TEST_F(SourcePositionTableTest, EncodeAscending) {
     code_offset += offsets[i];
     source_position += offsets[i];
     if (i % 2) {
-      builder.AddPosition(code_offset, source_position, true);
+      builder.AddPosition(code_offset, toPos(source_position), true);
     } else {
-      builder.AddPosition(code_offset, source_position, false);
+      builder.AddPosition(code_offset, toPos(source_position), false);
     }
   }
 
@@ -77,9 +79,9 @@ TEST_F(SourcePositionTableTest, EncodeAscending) {
     code_offset += offsets[i];
     source_position -= offsets[i];
     if (i % 2) {
-      builder.AddPosition(code_offset, source_position, true);
+      builder.AddPosition(code_offset, toPos(source_position), true);
     } else {
-      builder.AddPosition(code_offset, source_position, false);
+      builder.AddPosition(code_offset, toPos(source_position), false);
     }
   }