src/deoptimizer.cc - Issue 2451853002: Uniform and precise source positions for inlining

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/deoptimizer.cc

Issue 2451853002: Uniform and precise source positions for inlining (Closed)

Patch Set: fixed PodArray::copy_out Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/deoptimizer.cc

diff --git a/src/deoptimizer.cc b/src/deoptimizer.cc

index 6fe51bb3aff48ead9cde4b6b4139bf093a5c468c..aca106cc5fc22468a26ea1f0e98943c86abadbc1 100644

--- a/src/deoptimizer.cc

+++ b/src/deoptimizer.cc

@@ -2730,8 +2730,7 @@ Deoptimizer::DeoptInfo Deoptimizer::GetDeoptInfo(Code* code, Address pc) {

}

if (info->rmode() == RelocInfo::DEOPT_POSITION) {

int raw_position = static_cast<int>(info->data());

- last_position = raw_position ? SourcePosition::FromRaw(raw_position)

- : SourcePosition::Unknown();

+ last_position.Decode(raw_position);

} else if (info->rmode() == RelocInfo::DEOPT_ID) {

last_deopt_id = static_cast<int>(info->data());

} else if (info->rmode() == RelocInfo::DEOPT_REASON) {