Uniform and precise source positions for inlining

src/assembler.cc

Index: src/assembler.cc
diff --git a/src/assembler.cc b/src/assembler.cc
index 676a9febdbff695b79db82dadfa5a1958125d143..d54dd6dda17ae2b44b660a01fb0bdc0ee2ecebef 100644
--- a/src/assembler.cc
+++ b/src/assembler.cc
@@ -1891,11 +1891,12 @@ int ConstantPoolBuilder::Emit(Assembler* assm) {
 
 // Platform specific but identical code for all the platforms.
 
-void Assembler::RecordDeoptReason(DeoptimizeReason reason, int raw_position,
-                                  int id) {
+void Assembler::RecordDeoptReason(DeoptimizeReason reason,
+                                  SourcePosition position, int id) {
   if (FLAG_trace_deopt || isolate()->is_profiling()) {
     EnsureSpace ensure_space(this);
-    RecordRelocInfo(RelocInfo::DEOPT_POSITION, raw_position);
+    RecordRelocInfo(RelocInfo::DEOPT_POSITION, position.EncodeScriptOffset());
+    RecordRelocInfo(RelocInfo::DEOPT_POSITION, position.EncodeInliningId());

[Yang, 2016/11/04 14:32:59]

Does it make sense to have one single reloc info entry for both? Or is changing
the reloc info format for this not worth saving the reloc info header?

Also, would it make sense to store this position information into the separate
source position table instead?

[Tobias Tebbi, 2016/11/07 15:10:34]

Changing the RelocInfo entry seems difficult, because RelocInfo only has an
intptr_t data field. Puting the source position in the SourcePositionTable seems
reasonable, but I consider this too big a change to meld into this already
oversized CL.

     RecordRelocInfo(RelocInfo::DEOPT_REASON, static_cast<int>(reason));
     RecordRelocInfo(RelocInfo::DEOPT_ID, id);
   }