Uniform and precise source positions for inlining

src/profiler/profiler-listener.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/profiler/profiler-listener.h"
 
 #include "src/deoptimizer.h"
 #include "src/profiler/cpu-profiler.h"
 #include "src/profiler/profile-generator-inl.h"
 #include "src/source-position-table.h"
@@ skipping 76 matching lines @@
   Script* script = Script::cast(shared->script());
   JITLineInfoTable* line_table = NULL;
   if (script) {
     line_table = new JITLineInfoTable();
     int offset = abstract_code->IsCode() ? Code::kHeaderSize
                                          : BytecodeArray::kHeaderSize;
     int start_position = shared->start_position();
     int end_position = shared->end_position();
     for (SourcePositionTableIterator it(abstract_code->source_position_table());
          !it.done(); it.Advance()) {
-      int position = it.source_position();
+      int position = it.source_position().ScriptOffset();
       // TODO(alph): in case of inlining the position may correspond to an
       // inlined function source code. Do not collect positions that fall
       // beyond the function source code. There's however a chance the
       // inlined function has similar positions but in another script. So
       // the proper fix is to store script_id in some form along with the
       // inlined function positions.
       if (position < start_position || position >= end_position) continue;
       int line_number = script->GetLineNumber(position) + 1;
       int pc_offset = it.code_offset() + offset;
       line_table->SetPosition(pc_offset, line_number);
@@ skipping 220 matching lines @@
 
 void ProfilerListener::RemoveObserver(CodeEventObserver* observer) {
   base::LockGuard<base::Mutex> guard(&mutex_);
   auto it = std::find(observers_.begin(), observers_.end(), observer);
   if (it == observers_.end()) return;
   observers_.erase(it);
 }
 
 }  // namespace internal
 }  // namespace v8