Uniform and precise source positions for inlining

src/assembler.h

 // Copyright (c) 1994-2006 Sun Microsystems Inc.
 // All Rights Reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 // - Redistributions of source code must retain the above copyright notice,
 // this list of conditions and the following disclaimer.
 //
@@ skipping 25 matching lines @@
 #define V8_ASSEMBLER_H_
 
 #include "src/allocation.h"
 #include "src/builtins/builtins.h"
 #include "src/deoptimize-reason.h"
 #include "src/globals.h"
 #include "src/isolate.h"
 #include "src/log.h"
 #include "src/register-configuration.h"
 #include "src/runtime/runtime.h"
+#include "src/source-position.h"

[Michael Starzinger, 2016/10/28 08:45:50]

nit: I assume this include was added because of the changed signature of
{RecordDeoptReason}. Since it is only used in the signature, we should be able
to get by with a forward declaration in this header file instead.

This applies more broadly throughout the CL: If a forward declaration is
sufficient within a header file, then we usually go with the forward
declaration. That way the include dependency graph for headers stays small,
(re)compilation times decrease and the chance for cyclic dependency is reduced.

 
 namespace v8 {
 
 // Forward declarations.
 class ApiFunction;
 
 namespace internal {
 
 // Forward declarations.
 class StatsCounter;
@@ skipping 1224 matching lines @@
     std::vector<ConstantPoolEntry> shared_entries;
   };
 
   Label emitted_label_;  // Records pc_offset of emitted pool
   PerTypeEntryInfo info_[ConstantPoolEntry::NUMBER_OF_TYPES];
 };
 
 }  // namespace internal
 }  // namespace v8
 #endif  // V8_ASSEMBLER_H_