Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Side by Side Diff: src/crankshaft/x87/lithium-x87.cc

Issue 2451853002: Uniform and precise source positions for inlining (Closed)
Patch Set: addressed comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/crankshaft/x87/lithium-x87.h" 5 #include "src/crankshaft/x87/lithium-x87.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #if V8_TARGET_ARCH_X87 9 #if V8_TARGET_ARCH_X87
10 10
(...skipping 2396 matching lines...) Expand 10 before | Expand all | Expand 10 after
2407 HEnvironment* inner = outer->CopyForInlining( 2407 HEnvironment* inner = outer->CopyForInlining(
2408 instr->closure(), instr->arguments_count(), instr->function(), undefined, 2408 instr->closure(), instr->arguments_count(), instr->function(), undefined,
2409 instr->inlining_kind(), instr->syntactic_tail_call_mode()); 2409 instr->inlining_kind(), instr->syntactic_tail_call_mode());
2410 // Only replay binding of arguments object if it wasn't removed from graph. 2410 // Only replay binding of arguments object if it wasn't removed from graph.
2411 if (instr->arguments_var() != NULL && instr->arguments_object()->IsLinked()) { 2411 if (instr->arguments_var() != NULL && instr->arguments_object()->IsLinked()) {
2412 inner->Bind(instr->arguments_var(), instr->arguments_object()); 2412 inner->Bind(instr->arguments_var(), instr->arguments_object());
2413 } 2413 }
2414 inner->BindContext(instr->closure_context()); 2414 inner->BindContext(instr->closure_context());
2415 inner->set_entry(instr); 2415 inner->set_entry(instr);
2416 current_block_->UpdateEnvironment(inner); 2416 current_block_->UpdateEnvironment(inner);
2417 chunk_->AddInlinedFunction(instr->shared()); 2417
2418 return NULL; 2418 return NULL;
2419 } 2419 }
2420 2420
2421 2421
2422 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) { 2422 LInstruction* LChunkBuilder::DoLeaveInlined(HLeaveInlined* instr) {
2423 LInstruction* pop = NULL; 2423 LInstruction* pop = NULL;
2424 2424
2425 HEnvironment* env = current_block_->last_environment(); 2425 HEnvironment* env = current_block_->last_environment();
2426 2426
2427 if (env->entry()->arguments_pushed()) { 2427 if (env->entry()->arguments_pushed()) {
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
2464 LOperand* index = UseTempRegister(instr->index()); 2464 LOperand* index = UseTempRegister(instr->index());
2465 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index); 2465 LLoadFieldByIndex* load = new(zone()) LLoadFieldByIndex(object, index);
2466 LInstruction* result = DefineSameAsFirst(load); 2466 LInstruction* result = DefineSameAsFirst(load);
2467 return AssignPointerMap(result); 2467 return AssignPointerMap(result);
2468 } 2468 }
2469 2469
2470 } // namespace internal 2470 } // namespace internal
2471 } // namespace v8 2471 } // namespace v8
2472 2472
2473 #endif // V8_TARGET_ARCH_X87 2473 #endif // V8_TARGET_ARCH_X87
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698