Uniform and precise source positions for inlining

src/compiler/graph-visualizer.cc

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/graph-visualizer.h"
 
 #include <memory>
 #include <sstream>
 #include <string>
 
 #include "src/code-stubs.h"
 #include "src/compilation-info.h"
 #include "src/compiler/all-nodes.h"
+#include "src/compiler/compiler-source-position-table.h"
 #include "src/compiler/graph.h"
 #include "src/compiler/node-properties.h"
 #include "src/compiler/node.h"
 #include "src/compiler/opcodes.h"
 #include "src/compiler/operator-properties.h"
 #include "src/compiler/operator.h"
 #include "src/compiler/register-allocator.h"
 #include "src/compiler/schedule.h"
 #include "src/compiler/scheduler.h"
 #include "src/interpreter/bytecodes.h"
@@ skipping 120 matching lines @@
     } else if (opcode == IrOpcode::kIfTrue || opcode == IrOpcode::kIfFalse ||
                opcode == IrOpcode::kLoop) {
       os_ << ",\"rankInputs\":[" << NodeProperties::FirstControlIndex(node)
           << "]";
     }
     if (opcode == IrOpcode::kBranch) {
       os_ << ",\"rankInputs\":[0]";
     }
     SourcePosition position = positions_->GetSourcePosition(node);
     if (position.IsKnown()) {
-      os_ << ",\"pos\":" << position.raw();
+      os_ << ",\"pos\":" << position.ScriptOffset();

[Yang, 2016/11/04 14:32:59]

Also here, include inlining id as well?

[Tobias Tebbi, 2016/11/07 15:10:34]

Yes, but Turbolizer also needs support for this, so I would also like to do this
in a separate CL.

     }
     os_ << ",\"opcode\":\"" << IrOpcode::Mnemonic(node->opcode()) << "\"";
     os_ << ",\"control\":" << (NodeProperties::IsControl(node) ? "true"
                                                                : "false");
     os_ << ",\"opinfo\":\"" << node->op()->ValueInputCount() << " v "
         << node->op()->EffectInputCount() << " eff "
         << node->op()->ControlInputCount() << " ctrl in, "
         << node->op()->ValueOutputCount() << " v "
         << node->op()->EffectOutputCount() << " eff "
         << node->op()->ControlOutputCount() << " ctrl out\"";
@@ skipping 324 matching lines @@
         PrintIndent();
         os_ << "0 " << uses << " ";
         PrintNode(node);
         if (FLAG_trace_turbo_types) {
           os_ << " ";
           PrintType(node);
         }
         if (positions != nullptr) {
           SourcePosition position = positions->GetSourcePosition(node);
           if (position.IsKnown()) {
-            os_ << " pos:" << position.raw();
+            os_ << " pos:" << position.ScriptOffset();

[Yang, 2016/11/04 14:32:59]

Same here.

           }
         }
         os_ << " <|@\n";
       }
 
       BasicBlock::Control control = current->control();
       if (control != BasicBlock::kNone) {
         PrintIndent();
         os_ << "0 0 ";
         if (current->control_input() != nullptr) {
@@ skipping 193 matching lines @@
         os << "]";
       }
       os << std::endl;
     }
   }
   return os;
 }
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8