ios/chrome/browser/reading_list/reading_list_web_state_observer.mm - Issue 2451843002: Add Store+Sync to reading list.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

Issue 2451843002: Add Store+Sync to reading list. (Closed)

Patch Set: fix xcode clang Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

diff --git a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

index 04333916ae03938e34a2a61e4b68b2942318e72a..c12abae78171eafa251ea9e0b5a0ec03647c861e 100644

--- a/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

+++ b/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm

@@ -110,7 +110,8 @@ void ReadingListWebStateObserver::VerifyIfReadingListEntryStartedLoading() {

double progress = web_state()->GetLoadingProgress();

const double kMinimumExpectedProgress = 0.15;

if (progress < kMinimumExpectedProgress) {

- const ReadingListEntry* entry = reading_list_model_->GetEntryFromURL(url);

+ const ReadingListEntry* entry =

+ reading_list_model_->GetEntryFromURL(url, nullptr);

if (!entry)

return;

// TODO(crbug.com/664124) Actually load offline pages.