Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: components/browser_sync/profile_sync_components_factory_impl.cc

Issue 2451843002: Add Store+Sync to reading list. (Closed)
Patch Set: rebase Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_components_factory_impl.cc
diff --git a/components/browser_sync/profile_sync_components_factory_impl.cc b/components/browser_sync/profile_sync_components_factory_impl.cc
index f71096c80b08db9f02f09e32904a0a1aea4f7899..b37b4e5959a303e01dbc4d455ac045bcd33a6842 100644
--- a/components/browser_sync/profile_sync_components_factory_impl.cc
+++ b/components/browser_sync/profile_sync_components_factory_impl.cc
@@ -274,6 +274,14 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
base::MakeUnique<UIDataTypeController>(syncer::ARTICLES, error_callback,
sync_client_));
}
+ // Reading list sync is enabled by default. Register unless explicitly
+ // disabled.
+ if (!disabled_types.Has(syncer::READING_LIST)) {
+ sync_service->RegisterDataTypeController(
+ base::MakeUnique<ModelTypeController>(
+ syncer::READING_LIST, base::Bind(&base::debug::DumpWithoutCrashing),
pavely 2016/11/14 07:45:33 It's Ok to pass base::debug::DumpWithoutCrashing d
Olivier 2016/11/14 11:36:48 Directly switched to error_callback
+ sync_client_, base::ThreadTaskRunnerHandle::Get()));
+ }
}
DataTypeManager* ProfileSyncComponentsFactoryImpl::CreateDataTypeManager(
« no previous file with comments | « no previous file | components/sync/protocol/reading_list_specifics.proto » ('j') | ios/chrome/browser/reading_list/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698