Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Unified Diff: components/browser_sync/profile_sync_components_factory_impl.cc

Issue 2451843002: Add Store+Sync to reading list. (Closed)
Patch Set: reading_list_model_unittests Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/browser_sync/profile_sync_components_factory_impl.cc
diff --git a/components/browser_sync/profile_sync_components_factory_impl.cc b/components/browser_sync/profile_sync_components_factory_impl.cc
index 2c15aafe5be1a671f6dc3fdf146cb500be9ed0ca..809866ef760379c017fd36b7fd0094e173b89767 100644
--- a/components/browser_sync/profile_sync_components_factory_impl.cc
+++ b/components/browser_sync/profile_sync_components_factory_impl.cc
@@ -282,6 +282,14 @@ void ProfileSyncComponentsFactoryImpl::RegisterCommonDataTypes(
base::MakeUnique<UIDataTypeController>(syncer::ARTICLES, error_callback,
sync_client_));
}
+ // Reading list sync is disabled by default. Register only if explicitly
+ // enabled.
+ if (!disabled_types.Has(syncer::READING_LIST)) {
jif 2016/11/07 12:30:51 Shouldn't it be: // Reading list sync is enabled b
Olivier 2016/11/07 18:18:45 Done.
+ sync_service->RegisterDataTypeController(
+ base::MakeUnique<ModelTypeController>(
+ syncer::READING_LIST, base::Bind(&base::debug::DumpWithoutCrashing),
+ sync_client_, base::ThreadTaskRunnerHandle::Get()));
+ }
}
DataTypeManager* ProfileSyncComponentsFactoryImpl::CreateDataTypeManager(
« no previous file with comments | « no previous file | components/sync/protocol/reading_list_specifics.proto » ('j') | ios/chrome/browser/prefs/browser_prefs.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698