Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(585)

Issue 2451813002: Enable the iPad Tab Switcher by default. (Closed)

Created:
4 years, 1 month ago by jif
Modified:
4 years, 1 month ago
Reviewers:
droger
CC:
chromium-reviews, mac-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable the iPad Tab Switcher by default. BUG=659942 Committed: https://crrev.com/0fb9f22e1484df571ee2e776beda35ce02d0e80c Cr-Commit-Position: refs/heads/master@{#429242}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M ios/chrome/browser/experimental_flags.mm View 1 chunk +5 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
jif
ptal Notes: -can't remove kEnableTabSwitcher because it's used downstream, will do so in follow up ...
4 years, 1 month ago (2016-10-27 09:44:50 UTC) #4
droger
rs lgtm
4 years, 1 month ago (2016-10-27 12:00:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451813002/20001
4 years, 1 month ago (2016-11-02 08:47:26 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 1 month ago (2016-11-02 09:15:16 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0fb9f22e1484df571ee2e776beda35ce02d0e80c Cr-Commit-Position: refs/heads/master@{#429242}
4 years, 1 month ago (2016-11-02 09:17:56 UTC) #16
rohitrao (ping after 24h)
4 years, 1 month ago (2016-11-05 12:39:24 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:20001) has been created in
https://codereview.chromium.org/2480013003/ by rohitrao@chromium.org.

The reason for reverting is: Reverting to see if this is the cause of iOS tablet
test failures..

Powered by Google App Engine
This is Rietveld 408576698