Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2451793003: [Sync] Avoid sending the processor metadata again on re-enabling sync. (Closed)

Created:
4 years, 1 month ago by skym
Modified:
4 years, 1 month ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Avoid sending the processor metadata again on re-enabling sync. BUG=658735 Committed: https://crrev.com/07030cf31bf5c6b7d1180ddc4033e452086ec0c3 Cr-Commit-Position: refs/heads/master@{#427478}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update for Max. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -1 line) Patch
M components/sync/device_info/device_info_service.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M components/sync/device_info/device_info_service_unittest.cc View 1 2 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 18 (10 generated)
skym
PTAL, currently causing crashes on Canary.
4 years, 1 month ago (2016-10-25 17:54:51 UTC) #3
maxbogue
lgtm https://codereview.chromium.org/2451793003/diff/1/components/sync/device_info/device_info_service_unittest.cc File components/sync/device_info/device_info_service_unittest.cc (right): https://codereview.chromium.org/2451793003/diff/1/components/sync/device_info/device_info_service_unittest.cc#newcode735 components/sync/device_info/device_info_service_unittest.cc:735: set_local_device(base::WrapUnique(new LocalDeviceInfoProviderMock())); MakeUnique?
4 years, 1 month ago (2016-10-25 19:28:34 UTC) #7
skym
https://codereview.chromium.org/2451793003/diff/1/components/sync/device_info/device_info_service_unittest.cc File components/sync/device_info/device_info_service_unittest.cc (right): https://codereview.chromium.org/2451793003/diff/1/components/sync/device_info/device_info_service_unittest.cc#newcode735 components/sync/device_info/device_info_service_unittest.cc:735: set_local_device(base::WrapUnique(new LocalDeviceInfoProviderMock())); On 2016/10/25 19:28:33, maxbogue wrote: > MakeUnique? ...
4 years, 1 month ago (2016-10-25 19:32:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451793003/10001
4 years, 1 month ago (2016-10-25 19:33:27 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/283546)
4 years, 1 month ago (2016-10-25 20:37:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451793003/10001
4 years, 1 month ago (2016-10-25 20:47:36 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:10001)
4 years, 1 month ago (2016-10-25 21:24:24 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-10-25 21:27:50 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/07030cf31bf5c6b7d1180ddc4033e452086ec0c3
Cr-Commit-Position: refs/heads/master@{#427478}

Powered by Google App Engine
This is Rietveld 408576698