Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2451783002: [sensors] Fix component build warnings for windows platform (Closed)

Created:
4 years, 1 month ago by shalamov
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[sensors] Fix component build warnings for windows platform This CL changes device/generic_sensor/public/cpp/ from source_set type to component. BUG=606766 Committed: https://crrev.com/aca064c217fc134807c9f6bb28573226e07a885f Cr-Commit-Position: refs/heads/master@{#427613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M device/generic_sensor/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M device/generic_sensor/public/cpp/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M device/generic_sensor/public/cpp/sensor_reading.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/sensor/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
shalamov
PTAL
4 years, 1 month ago (2016-10-25 13:56:52 UTC) #4
Mikhail
lgtm
4 years, 1 month ago (2016-10-25 14:39:14 UTC) #5
darktears
On 2016/10/25 at 15:32:22, commit-bot wrote: > Dry run: This issue passed the CQ dry ...
4 years, 1 month ago (2016-10-25 15:57:03 UTC) #8
Reilly Grant (use Gerrit)
lgtm
4 years, 1 month ago (2016-10-25 17:37:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451783002/1
4 years, 1 month ago (2016-10-26 06:28:59 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-26 06:36:34 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 06:40:18 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aca064c217fc134807c9f6bb28573226e07a885f
Cr-Commit-Position: refs/heads/master@{#427613}

Powered by Google App Engine
This is Rietveld 408576698