Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2451713003: Revert of [Telemetry] Remove logic of pulling out user_agent_type from page_set (Closed)

Created:
4 years, 1 month ago by nednguyen(REVIEW IN OTHER ACC)
Modified:
4 years, 1 month ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Revert of [Telemetry] Remove logic of pulling out user_agent_type from page_set (patchset #1 id:1 of https://codereview.chromium.org/2447563003/ ) Reason for revert: Cause failure on waterfall. Original issue's description: > [Telemetry] Remove logic of pulling out user_agent_type from page_set > > BUG=chromium:439512 > > Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/7aa9328a154ab90699470e084506c437c7426685 TBR=aiolos@chromium.org,nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:439512 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4440fabbbce3cd9fdb57116ecb9e190a559883ec

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M telemetry/telemetry/page/shared_page_state.py View 1 chunk +13 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
nednguyen(REVIEW IN OTHER ACC)
Created Revert of [Telemetry] Remove logic of pulling out user_agent_type from page_set
4 years, 1 month ago (2016-10-25 12:26:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451713003/1
4 years, 1 month ago (2016-10-25 12:26:35 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/4440fabbbce3cd9fdb57116ecb9e190a559883ec
4 years, 1 month ago (2016-10-25 12:26:42 UTC) #5
nednguyen
4 years, 1 month ago (2016-10-25 12:37:53 UTC) #6
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2447003003/ by nednguyen@google.com.

The reason for reverting is: False alert..

Powered by Google App Engine
This is Rietveld 408576698