Propagate the read_only_hardware flag of volumes to js.

chrome/browser/chromeos/file_manager/volume_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_FILE_MANAGER_VOLUME_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_FILE_MANAGER_VOLUME_MANAGER_H_
 
 #include <map>
 #include <memory>
 #include <string>
@@ skipping 98 matching lines @@
   const base::FilePath& mount_path() const { return mount_path_; }
   chromeos::disks::MountCondition mount_condition() const {
     return mount_condition_;
   }
   MountContext mount_context() const { return mount_context_; }
   const base::FilePath& system_path_prefix() const {
     return system_path_prefix_;
   }
   const std::string& volume_label() const { return volume_label_; }
   bool is_parent() const { return is_parent_; }
+  // Whether the device is writable by applications.
   bool is_read_only() const { return is_read_only_; }
+  // Whether the device is write-protected by hardware. This field is valid
+  // only when device_type is VOLUME_TYPE_REMOVABLE_DISK_PARTITION and
+  // source is SOURCE_DEVICE.
+  // When this value is true, is_read_only() is also true.

[fukino, 2016/10/26 07:23:31]

Could you mention an example in which is_read_only_ is true but
is_read_only_hardware_ is false.

In CL description or code comment, could you explain why we need to have these
two separated fields.

[yamaguchi, 2016/10/26 11:14:20]

Done.
Described for what this change is, in the CL description.

+  bool is_read_only_hardware() const { return is_read_only_hardware_; }
   bool has_media() const { return has_media_; }
   bool configurable() const { return configurable_; }
   bool watchable() const { return watchable_; }
 
  private:
   Volume();
 
   // The ID of the volume.
   std::string volume_id_;
 
@@ skipping 38 matching lines @@
   base::FilePath system_path_prefix_;
 
   // Label for the volume if the volume is either removable or a provided
   // file system. In case of removables, if disk is a parent, then its label,
   // else parents label (e.g. "TransMemory").
   std::string volume_label_;
 
   // Is the device is a parent device (i.e. sdb rather than sdb1).
   bool is_parent_;
 
-  // True if the volume is read only.
+  // True if the volume is not writable by applications.
   bool is_read_only_;
 
+  // True if the volume is made read_only due to its hardware.
+  // This implies is_read_only_.
+  bool is_read_only_hardware_;
+
   // True if the volume contains media.
   bool has_media_;
 
   // True if the volume is configurable.
   bool configurable_;
 
   // True if the volume notifies about changes via file/directory watchers.
   bool watchable_;
 
   DISALLOW_COPY_AND_ASSIGN(Volume);
@@ skipping 126 matching lines @@
 
   // Note: This should remain the last member so it'll be destroyed and
   // invalidate its weak pointers before any other members are destroyed.
   base::WeakPtrFactory<VolumeManager> weak_ptr_factory_;
   DISALLOW_COPY_AND_ASSIGN(VolumeManager);
 };
 
 }  // namespace file_manager
 
 #endif  // CHROME_BROWSER_CHROMEOS_FILE_MANAGER_VOLUME_MANAGER_H_