Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 2451673002: Trim leading and trailing whitespace from stored CSP headers. (Closed)

Created:
4 years, 1 month ago by Mike West
Modified:
4 years, 1 month ago
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Trim leading and trailing whitespace from stored CSP headers. mikispag@ noticed in [1] that we're adding whitespace to the original policy when processing multiple headers. This patch strips whitespace, which means we're storing less data, and sending what developers expect to see in the violation reports. [1]: https://github.com/w3c/web-platform-tests/pull/4020 R=jochen@chromium.org Committed: https://crrev.com/797cafaafd05de0ad7baeef814214fecb11d13d7 Cr-Commit-Position: refs/heads/master@{#427657}

Patch Set 1 #

Patch Set 2 : ASAN #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveListTest.cpp View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Mike West
WDYT of this small change, Jochen?
4 years, 1 month ago (2016-10-25 07:31:34 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-10-26 08:23:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2451673002/20001
4 years, 1 month ago (2016-10-26 08:43:31 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-26 10:17:41 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-26 10:19:28 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/797cafaafd05de0ad7baeef814214fecb11d13d7
Cr-Commit-Position: refs/heads/master@{#427657}

Powered by Google App Engine
This is Rietveld 408576698