chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java - Issue 2451633004: Fix an issue that opening a download with remapped MIME type will launch an intent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

Issue 2451633004: Fix an issue that opening a download with remapped MIME type will launch an intent (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/download/ui/BackendProvider.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/download/ui/StubbedProvider.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

index ea268d48da20580281ea2fe3c7cc27033859e2c0..8a92f12e6302dd7d303c5ecbaafba48bd9ebf48f 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/download/ui/DownloadHistoryItemWrapper.java

@@ -180,7 +180,7 @@ public abstract class DownloadHistoryItemWrapper implements TimedItem {

// Check if Chrome should open the file itself.

if (mBackendProvider.getDownloadDelegate().isDownloadOpenableInBrowser(

- mItem.getId(), mIsOffTheRecord)) {

+ mItem.getId(), mIsOffTheRecord, getMimeType())) {

// Share URIs use the content:// scheme when able, which looks bad when displayed

// in the URL bar.

Uri fileUri = Uri.fromFile(getFile());