Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc

Issue 2451623005: Remove Dangerous indicator after going back from interstitial (Closed)
Patch Set: another typo fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
index 0a6e6f68d37ca1800510c40811be80dab00bc887..41f222e988feed8878c5c6f4520b9ef2ad051d0d 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.cc
@@ -324,7 +324,8 @@ void SafeBrowsingBlockingPage::OnProceed() {
FinishThreatDetails(threat_details_proceed_delay_ms_, true, /* did_proceed */
controller()->metrics_helper()->NumVisits());
- ui_manager_->OnBlockingPageDone(unsafe_resources_, true);
+ ui_manager_->OnBlockingPageDone(unsafe_resources_, true, web_contents(),
+ main_frame_url_);
// Check to see if some new notifications of unsafe resources have been
// received while we were showing the interstitial.
@@ -373,14 +374,16 @@ void SafeBrowsingBlockingPage::OnDontProceed() {
FinishThreatDetails(0, false /* did_proceed */,
controller()->metrics_helper()->NumVisits()); // No delay
- ui_manager_->OnBlockingPageDone(unsafe_resources_, false);
+ ui_manager_->OnBlockingPageDone(unsafe_resources_, false, web_contents(),
+ main_frame_url_);
// The user does not want to proceed, clear the queued unsafe resources
// notifications we received while the interstitial was showing.
UnsafeResourceMap* unsafe_resource_map = GetUnsafeResourcesMap();
UnsafeResourceMap::iterator iter = unsafe_resource_map->find(web_contents());
if (iter != unsafe_resource_map->end() && !iter->second.empty()) {
- ui_manager_->OnBlockingPageDone(iter->second, false);
+ ui_manager_->OnBlockingPageDone(iter->second, false, web_contents(),
+ main_frame_url_);
unsafe_resource_map->erase(iter);
}
« no previous file with comments | « no previous file | chrome/browser/safe_browsing/safe_browsing_blocking_page_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698