Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: chrome/browser/safe_browsing/ui_manager_unittest.cc

Issue 2451623005: Remove Dangerous indicator after going back from interstitial (Closed)
Patch Set: another typo fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/safe_browsing/ui_manager.h" 5 #include "chrome/browser/safe_browsing/ui_manager.h"
6 6
7 #include "base/run_loop.h" 7 #include "base/run_loop.h"
8 #include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h" 8 #include "chrome/browser/safe_browsing/safe_browsing_blocking_page.h"
9 #include "chrome/browser/safe_browsing/safe_browsing_service.h" 9 #include "chrome/browser/safe_browsing/safe_browsing_service.h"
10 #include "chrome/browser/safe_browsing/ui_manager.h" 10 #include "chrome/browser/safe_browsing/ui_manager.h"
11 #include "chrome/test/base/chrome_render_view_host_test_harness.h" 11 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
12 #include "chrome/test/base/testing_profile.h" 12 #include "chrome/test/base/testing_profile.h"
13 #include "components/safe_browsing_db/safe_browsing_prefs.h" 13 #include "components/safe_browsing_db/safe_browsing_prefs.h"
14 #include "components/safe_browsing_db/util.h" 14 #include "components/safe_browsing_db/util.h"
15 #include "content/public/browser/navigation_entry.h"
15 #include "content/public/browser/render_process_host.h" 16 #include "content/public/browser/render_process_host.h"
16 #include "content/public/browser/render_view_host.h" 17 #include "content/public/browser/render_view_host.h"
17 #include "content/public/browser/web_contents.h" 18 #include "content/public/browser/web_contents.h"
18 #include "content/public/browser/web_contents_delegate.h" 19 #include "content/public/browser/web_contents_delegate.h"
19 #include "content/public/test/test_browser_thread_bundle.h" 20 #include "content/public/test/test_browser_thread_bundle.h"
20 #include "content/public/test/web_contents_tester.h" 21 #include "content/public/test/web_contents_tester.h"
21 #include "testing/gtest/include/gtest/gtest.h" 22 #include "testing/gtest/include/gtest/gtest.h"
22 #include "url/gurl.h" 23 #include "url/gurl.h"
23 24
24 using content::BrowserThread; 25 using content::BrowserThread;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 67
67 class SafeBrowsingUIManagerTest : public ChromeRenderViewHostTestHarness { 68 class SafeBrowsingUIManagerTest : public ChromeRenderViewHostTestHarness {
68 public: 69 public:
69 SafeBrowsingUIManagerTest() : ui_manager_(new SafeBrowsingUIManager(NULL)) {} 70 SafeBrowsingUIManagerTest() : ui_manager_(new SafeBrowsingUIManager(NULL)) {}
70 71
71 ~SafeBrowsingUIManagerTest() override{}; 72 ~SafeBrowsingUIManagerTest() override{};
72 73
73 void SetUp() override { 74 void SetUp() override {
74 SetThreadBundleOptions(content::TestBrowserThreadBundle::REAL_IO_THREAD); 75 SetThreadBundleOptions(content::TestBrowserThreadBundle::REAL_IO_THREAD);
75 ChromeRenderViewHostTestHarness::SetUp(); 76 ChromeRenderViewHostTestHarness::SetUp();
77 SafeBrowsingUIManager::CreateWhitelistForTesting(web_contents());
76 } 78 }
77 79
78 void TearDown() override { ChromeRenderViewHostTestHarness::TearDown(); } 80 void TearDown() override { ChromeRenderViewHostTestHarness::TearDown(); }
79 81
80 bool IsWhitelisted(SafeBrowsingUIManager::UnsafeResource resource) { 82 bool IsWhitelisted(SafeBrowsingUIManager::UnsafeResource resource) {
81 return ui_manager_->IsWhitelisted(resource); 83 return ui_manager_->IsWhitelisted(resource);
82 } 84 }
83 85
84 void AddToWhitelist(SafeBrowsingUIManager::UnsafeResource resource) { 86 void AddToWhitelist(SafeBrowsingUIManager::UnsafeResource resource) {
85 ui_manager_->AddToWhitelistUrlSet(resource, false); 87 ui_manager_->AddToWhitelistUrlSet(
88 SafeBrowsingUIManager::GetMainFrameWhitelistUrlForResourceForTesting(
89 resource),
90 web_contents(), false);
86 } 91 }
87 92
88 SafeBrowsingUIManager::UnsafeResource MakeUnsafeResource( 93 SafeBrowsingUIManager::UnsafeResource MakeUnsafeResource(
89 const char* url, 94 const char* url,
90 bool is_subresource) { 95 bool is_subresource) {
91 SafeBrowsingUIManager::UnsafeResource resource; 96 SafeBrowsingUIManager::UnsafeResource resource;
92 resource.url = GURL(url); 97 resource.url = GURL(url);
93 resource.is_subresource = is_subresource; 98 resource.is_subresource = is_subresource;
94 resource.web_contents_getter = 99 resource.web_contents_getter =
95 SafeBrowsingUIManager::UnsafeResource::GetWebContentsGetter( 100 SafeBrowsingUIManager::UnsafeResource::GetWebContentsGetter(
(...skipping 10 matching lines...) Expand all
106 111
107 // The WC doesn't have a URL without a navigation. A main-frame malware 112 // The WC doesn't have a URL without a navigation. A main-frame malware
108 // unsafe resource must be a pending navigation. 113 // unsafe resource must be a pending navigation.
109 content::WebContentsTester::For(web_contents())->StartNavigation(GURL(url)); 114 content::WebContentsTester::For(web_contents())->StartNavigation(GURL(url));
110 return resource; 115 return resource;
111 } 116 }
112 117
113 void SimulateBlockingPageDone( 118 void SimulateBlockingPageDone(
114 const std::vector<SafeBrowsingUIManager::UnsafeResource>& resources, 119 const std::vector<SafeBrowsingUIManager::UnsafeResource>& resources,
115 bool proceed) { 120 bool proceed) {
116 ui_manager_->OnBlockingPageDone(resources, proceed); 121 GURL main_frame_url;
122 content::NavigationEntry* entry =
123 web_contents()->GetController().GetVisibleEntry();
124 if (entry)
125 main_frame_url = entry->GetURL();
126
127 ui_manager_->OnBlockingPageDone(resources, proceed, web_contents(),
128 main_frame_url);
117 } 129 }
118 130
119 protected: 131 protected:
120 SafeBrowsingUIManager* ui_manager() { return ui_manager_.get(); } 132 SafeBrowsingUIManager* ui_manager() { return ui_manager_.get(); }
121 133
122 private: 134 private:
123 scoped_refptr<SafeBrowsingUIManager> ui_manager_; 135 scoped_refptr<SafeBrowsingUIManager> ui_manager_;
124 }; 136 };
125 137
126 TEST_F(SafeBrowsingUIManagerTest, Whitelist) { 138 TEST_F(SafeBrowsingUIManagerTest, Whitelist) {
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 SimulateBlockingPageDone(resources, true); 389 SimulateBlockingPageDone(resources, true);
378 EXPECT_TRUE(delegate.visible_security_state_changed()); 390 EXPECT_TRUE(delegate.visible_security_state_changed());
379 391
380 waiter.WaitForCallback(); 392 waiter.WaitForCallback();
381 EXPECT_TRUE(waiter.callback_called()); 393 EXPECT_TRUE(waiter.callback_called());
382 EXPECT_TRUE(waiter.proceed()); 394 EXPECT_TRUE(waiter.proceed());
383 EXPECT_TRUE(IsWhitelisted(resource)); 395 EXPECT_TRUE(IsWhitelisted(resource));
384 } 396 }
385 397
386 } // namespace safe_browsing 398 } // namespace safe_browsing
OLDNEW
« no previous file with comments | « chrome/browser/safe_browsing/ui_manager.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698