Get rid of createVisibleSelection() taking two Position

third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp

 /*
  * Copyright (C) 2005, 2006, 2007, 2008 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 594 matching lines @@
         if (tableElementJustAfter(visibleStart))
           return;
         // Extend the selection backward into the last cell, then deletion will
         // handle the move.
         selectionModifier.modify(FrameSelection::AlterationExtend,
                                  DirectionBackward, granularity);
         // If the caret is just after a table, select the table and don't delete
         // anything.
       } else if (Element* table = tableElementJustBefore(visibleStart)) {
         setEndingSelection(createVisibleSelection(
-            Position::beforeNode(table), endingSelection().start(),
-            TextAffinity::Downstream, endingSelection().isDirectional()));
+            SelectionInDOMTree::Builder()
+                .setBaseAndExtentDeprecated(Position::beforeNode(table),

[Xiaocheng, 2016/10/26 05:49:18]

We can use |setBaseAndExtent| since Position::beforeNode(table) cannot be null.

[yosin_UTC9, 2016/10/26 07:43:07]

Done.

+                                            endingSelection().start())
+                .setIsDirectional(endingSelection().isDirectional())
+                .build()));
         typingAddedToOpenCommand(DeleteKey);
         return;
       }
 
       selectionToDelete = selectionModifier.selection();
 
       if (granularity == CharacterGranularity &&
           selectionToDelete.end().computeContainerNode() ==
               selectionToDelete.start().computeContainerNode() &&
           selectionToDelete.end().computeOffsetInContainerNode() -
@@ skipping 96 matching lines @@
       if (visibleEnd.deepEquivalent() ==
           endOfParagraph(visibleEnd).deepEquivalent())
         downstreamEnd = mostForwardCaretPosition(
             nextPositionOf(visibleEnd, CannotCrossEditingBoundary)
                 .deepEquivalent());
       // When deleting tables: Select the table first, then perform the deletion
       if (isDisplayInsideTable(downstreamEnd.computeContainerNode()) &&
           downstreamEnd.computeOffsetInContainerNode() <=
               caretMinOffset(downstreamEnd.computeContainerNode())) {
         setEndingSelection(createVisibleSelection(
-            endingSelection().end(),
-            Position::afterNode(downstreamEnd.computeContainerNode()),
-            TextAffinity::Downstream, endingSelection().isDirectional()));
+            SelectionInDOMTree::Builder()
+                .setBaseAndExtentDeprecated(
+                    endingSelection().end(),
+                    Position::afterNode(downstreamEnd.computeContainerNode()))
+                .setIsDirectional(endingSelection().isDirectional())
+                .build()));
         typingAddedToOpenCommand(ForwardDeleteKey);
         return;
       }
 
       // deleting to end of paragraph when at end of paragraph needs to merge
       // the next paragraph (if any)
       if (granularity == ParagraphBoundary &&
           selectionModifier.selection().isCaret() &&
           isEndOfParagraph(selectionModifier.selection().visibleEnd()))
         selectionModifier.modify(FrameSelection::AlterationExtend,
@@ skipping 81 matching lines @@
   }
   NOTREACHED();
   m_preservesTypingStyle = false;
 }
 
 bool TypingCommand::isTypingCommand() const {
   return true;
 }
 
 }  // namespace blink