Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/core/editing/commands/CreateLinkCommand.cpp

Issue 2451613003: Get rid of createVisibleSelection() taking two Position (Closed)
Patch Set: 2016-10-26T11:29:45 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
49 } else { 49 } else {
50 insertNodeAt(anchorElement, endingSelection().start(), editingState); 50 insertNodeAt(anchorElement, endingSelection().start(), editingState);
51 if (editingState->isAborted()) 51 if (editingState->isAborted())
52 return; 52 return;
53 Text* textNode = Text::create(document(), m_url); 53 Text* textNode = Text::create(document(), m_url);
54 appendNode(textNode, anchorElement, editingState); 54 appendNode(textNode, anchorElement, editingState);
55 if (editingState->isAborted()) 55 if (editingState->isAborted())
56 return; 56 return;
57 document().updateStyleAndLayoutIgnorePendingStylesheets(); 57 document().updateStyleAndLayoutIgnorePendingStylesheets();
58 setEndingSelection(createVisibleSelection( 58 setEndingSelection(createVisibleSelection(
59 Position::inParentBeforeNode(*anchorElement), 59 SelectionInDOMTree::Builder()
60 Position::inParentAfterNode(*anchorElement), TextAffinity::Downstream, 60 .collapse(Position::inParentBeforeNode(*anchorElement))
61 endingSelection().isDirectional())); 61 .extend(Position::inParentAfterNode(*anchorElement))
62 .setIsDirectional(endingSelection().isDirectional())
63 .build()));
62 } 64 }
63 } 65 }
64 66
65 InputEvent::InputType CreateLinkCommand::inputType() const { 67 InputEvent::InputType CreateLinkCommand::inputType() const {
66 return InputEvent::InputType::CreateLink; 68 return InputEvent::InputType::CreateLink;
67 } 69 }
68 70
69 } // namespace blink 71 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698