Get rid of createVisibleSelection() taking two Position

third_party/WebKit/Source/core/editing/SelectionAdjuster.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 179 matching lines @@
 static bool isCrossingShadowBoundaries(
     const VisibleSelectionInFlatTree& selection) {
   if (!selection.isRange())
     return false;
   TreeScope& treeScope = selection.base().anchorNode()->treeScope();
   return selection.extent().anchorNode()->treeScope() != treeScope ||
          selection.start().anchorNode()->treeScope() != treeScope ||
          selection.end().anchorNode()->treeScope() != treeScope;
 }
 
+// TODO(yosin): We should make |adjustSelectionInDOMTree()| to return
+// |VisibleSelection| once |VisibleSelection| constructor doesn't call
+// |validate()|.
 void SelectionAdjuster::adjustSelectionInDOMTree(
     VisibleSelection* selection,
     const VisibleSelectionInFlatTree& selectionInFlatTree) {
   if (selectionInFlatTree.isNone()) {
     *selection = VisibleSelection();
     return;
   }
 
   const Position& base = toPositionInDOMTree(selectionInFlatTree.base());
   const Position& extent = toPositionInDOMTree(selectionInFlatTree.extent());
 
   if (isCrossingShadowBoundaries(selectionInFlatTree)) {
     DCHECK(base.document());
 
     // TODO(xiaochengh): The use of updateStyleAndLayoutIgnorePendingStylesheets
     // needs to be audited.  See http://crbug.com/590369 for more details.
     // This layout update call cannot be hoisted out of the |if|, otherwise it's
     // going to cause performance regression (http://crbug.com/652301).
     // TODO(yosin): Implement and apply lazy visible selection validation so
     // that we don't need to update layout here.
     base.document()->updateStyleAndLayoutIgnorePendingStylesheets();
 
-    *selection = createVisibleSelection(base, extent);
+    *selection = createVisibleSelection(
+        SelectionInDOMTree::Builder().setBaseAndExtent(base, extent).build());
     return;
   }
 
   const Position& position1 = toPositionInDOMTree(selectionInFlatTree.start());
   const Position& position2 = toPositionInDOMTree(selectionInFlatTree.end());
   selection->m_base = base;
   selection->m_extent = extent;
   selection->m_affinity = selectionInFlatTree.m_affinity;
   selection->m_isDirectional = selectionInFlatTree.m_isDirectional;
   selection->m_granularity = selectionInFlatTree.m_granularity;
@@ skipping 57 matching lines @@
     return;
   }
   Node* const shadowHost = shadowHostEnd ? shadowHostEnd : shadowHostStart;
   const PositionInFlatTree& newStart =
       adjustPositionInFlatTreeForStart(selection->start(), shadowHost);
   selection->m_extent = newStart;
   selection->m_start = newStart;
 }
 
 }  // namespace blink