Chromium Code Reviews| Index: chrome/browser/ui/chrome_bubble_manager_unittest.cc |
| diff --git a/chrome/browser/ui/chrome_bubble_manager_unittest.cc b/chrome/browser/ui/chrome_bubble_manager_unittest.cc |
| index 7848085053953fe5926ec43051ae95d2d92ce073..3efdd1b2c8abab4717536f52092ae4e7cfe560a7 100644 |
| --- a/chrome/browser/ui/chrome_bubble_manager_unittest.cc |
| +++ b/chrome/browser/ui/chrome_bubble_manager_unittest.cc |
| @@ -73,6 +73,18 @@ TEST_F(ChromeBubbleManagerTest, CloseMockBubbleOnNavigate) { |
| ASSERT_FALSE(bubble_ref); |
| } |
| +TEST_F(ChromeBubbleManagerTest, NotCloseMockBubbleWhenIsInPageNavigation) { |
|
sky
2016/10/26 19:20:48
DontCloseBubbleWhenNavigationIsInPage.
juncai
2016/10/26 21:30:50
Done.
|
| + AddTab(browser(), GURL("https://foo/0")); |
| + |
| + std::unique_ptr<MockBubbleDelegate> delegate(new MockBubbleDelegate); |
| + BubbleReference bubble_ref = manager_->ShowBubble(std::move(delegate)); |
| + |
| + NavigateAndCommitActiveTab(GURL("https://foo/0#0")); |
| + |
| + ASSERT_TRUE(bubble_ref) |
| + << "The bubble shouldn't be destroyed when it is an in-page navigation."; |
| +} |
| + |
| TEST_F(ChromeBubbleManagerTest, CloseMockBubbleOnOwningFrameDestroy) { |
| AddTab(browser(), GURL("https://foo/0")); |