chrome/browser/ui/webui/media_router/media_router_test.cc - Issue 2451573003: [Media Router] Update Media Router flags post-launch.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/webui/media_router/media_router_test.cc

Issue 2451573003: [Media Router] Update Media Router flags post-launch. (Closed)

Patch Set: Remove Cast-extension-specific browser test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/ui/toolbar/media_router_contextual_menu_unittest.cc ('K') | « chrome/browser/ui/webui/media_router/media_router_test.h ('k') | chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "chrome/browser/ui/webui/media_router/media_router_test.h"	5 #include "chrome/browser/ui/webui/media_router/media_router_test.h"

6	6

7 #include "chrome/test/base/dialog_test_browser_window.h"	7 #include "chrome/test/base/dialog_test_browser_window.h"

8	8

9 MediaRouterTest::MediaRouterTest()	9 MediaRouterTest::MediaRouterTest() {}

10 : feature_override_(extensions::FeatureSwitch::media_router(), true) {}

11	10

12 MediaRouterTest::~MediaRouterTest() {	11 MediaRouterTest::~MediaRouterTest() {
	msw 2016/10/27 18:14:31 optional nit: {} formatting optional nit: {} formatting mark a. foltz 2016/10/27 20:16:50 Done. Show quoted text On 2016/10/27 at 18:14:31, msw wrote: > optional nit: {} formatting Done.
13 }	12 }

14	13

15 BrowserWindow* MediaRouterTest::CreateBrowserWindow() {	14 BrowserWindow* MediaRouterTest::CreateBrowserWindow() {

16 return new DialogTestBrowserWindow;	15 return new DialogTestBrowserWindow;
	msw 2016/10/27 18:14:31 aside: I wonder if we still need MediaRouterTest t aside: I wonder if we still need MediaRouterTest to be a subclass of BrowserWithTestWindowTest for this, or if some simplification can be made. mark a. foltz 2016/10/27 20:16:50 It looks like BrowserWithTestWindowTest calls this Show quoted text On 2016/10/27 at 18:14:31, msw wrote: > aside: I wonder if we still need MediaRouterTest to be a subclass of BrowserWithTestWindowTest for this, or if some simplification can be made. It looks like BrowserWithTestWindowTest calls this method and we're intentionally overriding it from the default.
17 }	16 }

OLD	NEW