[MD settings] move cookie tree management to cookie tree behavior

chrome/browser/resources/settings/site_settings/cookie_tree_node.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
- * @typedef {{hasChildren: boolean,
- *            id: string,
- *            title: string,
- *            totalUsage: string,
- *            type: string}}
- */
-var CookieDetails;
-
-/**
- * @typedef {{content: string,
- *            label: string}}
- */
-var CookieDataForDisplay;
-
-/**
  * @typedef {{title: string,
  *            id: string,
  *            data: CookieDetails}}
  */
 var CookieDataItem;
 
 /**
  * @typedef {{site: string,
  *            id: string,
  *            localData: string}}
  */
 var CookieDataSummaryItem;
 
 /**
  * @typedef {{id: string,
  *            start: number,
  *            children: !Array<CookieDetails>}}
  */
 var CookieList;
 
 /**
  * @typedef {{id: string,
- *            start: !number,
- *            count: !number}}
+ *            start: number,
+ *            count: number}}
  */
 var CookieRemovePacket;
 
 var categoryLabels = {
   'app_cache': loadTimeData.getString('cookieAppCache'),
   'cache_storage': loadTimeData.getString('cookieCacheStorage'),
   'channel_id': loadTimeData.getString('cookieChannelId'),
   'cookie': loadTimeData.getString('cookieSingular'),
   'database': loadTimeData.getString('cookieDatabaseStorage'),
   'file_system': loadTimeData.getString('cookieFileSystem'),
@@ skipping 18 matching lines @@
 
 cr.define('settings', function() {
   'use strict';
 
   /**
    * @constructor
    */
   function CookieTreeNode(data) {
     /**
      * The data for this cookie node.
-     * @private {CookieDetails}
+     * @type {CookieDetails}
      */
-    this.data_ = data;
+    this.data = data;
 
     /**
      * The child cookie nodes.
      * @private {!Array<!settings.CookieTreeNode>}
      */
     this.children_ = [];
   };
 
   CookieTreeNode.prototype = {
     /**
@@ skipping 15 matching lines @@
      * Looks up a parent node and adds a list of CookieTreeNodes to them.
      * @param {string} parentId The ID of the parent to add the nodes to.
      * @param {!settings.CookieTreeNode} startingNode The node to start with
      *     when looking for the parent node to add the children to.
      * @param {!Array<!CookieDetails>} newNodes The list containing the data to
          add.
      * @return {boolean} True if the parent node was found.
      */
     populateChildNodes: function(parentId, startingNode, newNodes) {
       for (var i = 0; i < startingNode.children_.length; ++i) {
-        if (startingNode.children_[i].data_.id == parentId) {
+        if (startingNode.children_[i].data.id == parentId) {
           this.addChildNodes(startingNode.children_[i], newNodes);
           return true;
         }
 
         if (this.populateChildNodes(
             parentId, startingNode.children_[i], newNodes)) {
           return true;
         }
       }
       return false;
@@ skipping 13 matching lines @@
 
     /**
      * Returns an array of cookies from the current node within the cookie tree.
      * @return {!Array<!CookieDataItem>} The Cookie List.
      */
     getCookieList: function() {
       var list = [];
 
       for (var group of this.children_) {
         for (var cookie of group.children_) {
-          list.push({title: cookie.data_.title,
-                     id: cookie.data_.id,
-                     data: cookie.data_});
+          list.push({title: cookie.data.title,
+                     id: cookie.data.id,
+                     data: cookie.data});
         }
       }
 
       return list;
     },
 
     /**
      * Get a summary list of all sites and their stored data.
      * @return {!Array<!CookieDataSummaryItem>} The summary list.
      */
     getSummaryList: function() {
       var list = [];
       for (var i = 0; i < this.children_.length; ++i) {
         var siteEntry = this.children_[i];
-        var title = siteEntry.data_.title;
-        var id = siteEntry.data_.id;
+        var title = siteEntry.data.title;
+        var id = siteEntry.data.id;
         var description = '';
 
         if (siteEntry.children_.length == 0)
           continue;
 
         for (var j = 0; j < siteEntry.children_.length; ++j) {
           var descriptionNode = siteEntry.children_[j];
           if (j > 0)
             description += ', ';
 
           // Some types, like quota, have no description nodes.
           var dataType = '';
-          if (descriptionNode.data_.type != undefined) {
-            dataType = descriptionNode.data_.type;
+          if (descriptionNode.data.type != undefined) {
+            dataType = descriptionNode.data.type;
           } else {
             // A description node might not have children when it's deleted.
             if (descriptionNode.children_.length > 0)
-              dataType = descriptionNode.children_[0].data_.type;
+              dataType = descriptionNode.children_[0].data.type;
           }
 
           var count =
               (dataType == 'cookie') ? descriptionNode.children_.length : 0;
           if (count > 1) {
             description += loadTimeData.getStringF('cookiePlural', count);
           } else {
             description += getCookieDataCategoryText(
-                dataType, descriptionNode.data_.totalUsage);
+                dataType, descriptionNode.data.totalUsage);
           }
 
         }
         list.push({ site: title, id: id, localData: description });
       }
       list.sort(function(a, b) {
         return a.site.localeCompare(b.site);
       });
       return list;
     },
 
     /**
      * Fetch a CookieTreeNode by ID.
      * @param {string} id The ID to look up.
      * @param {boolean} recursive Whether to search the children also.
      * @return {settings.CookieTreeNode} The node found, if any.
      */
     fetchNodeById: function(id, recursive) {
       for (var i = 0; i < this.children_.length; ++i) {
         if (this.children_[i] == null)
           return null;
-        if (this.children_[i].data_.id == id)
+        if (this.children_[i].data.id == id)
           return this.children_[i];
         if (recursive) {
           var node = this.children_[i].fetchNodeById(id, true);
           if (node != null)
             return node;
         }
       }
       return null;
     },
-
-    /**
-     * Get cookie data for a given HTML node.
-     * @return {!Array<CookieDataForDisplay>}
-     */
-    getCookieData: function(item) {
-      /** @type {!Array<CookieDataForDisplay>} */
-      var out = [];
-      var fields = cookieInfo[item.data_.type];
-      for (var field of fields) {
-        // Iterate through the keys found in |cookieInfo| for the given |type|
-        // and see if those keys are present in the data. If so, display them
-        // (in the order determined by |cookieInfo|).
-        var key = field[0];
-        if (item.data_[key].length > 0) {
-          var entry = /** @type {CookieDataForDisplay} */({
-            label: loadTimeData.getString(field[1]),
-            content: item.data_[key],
-          });
-          out.push(entry);
-        }
-      }
-      return out;
-    },
   };
 
   return {
     CookieTreeNode: CookieTreeNode,
   };
 });