[MD settings] move cookie tree management to cookie tree behavior

chrome/browser/resources/settings/site_settings/cookie_tree_node.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
- * @typedef {{hasChildren: boolean,
- *            id: string,
- *            title: string,
- *            totalUsage: string,
- *            type: string}}
- */
-var CookieDetails;
-
-/**
- * @typedef {{content: string,
- *            label: string}}
- */
-var CookieDataForDisplay;
-
-/**
  * @typedef {{title: string,
  *            id: string,
  *            data: CookieDetails}}
  */
 var CookieDataItem;
 
 /**
  * @typedef {{site: string,
  *            id: string,
  *            localData: string}}
  */
 var CookieDataSummaryItem;
 
 /**
  * @typedef {{id: string,
  *            start: number,
  *            children: !Array<CookieDetails>}}
  */
 var CookieList;
 
 /**
  * @typedef {{id: string,
- *            start: !number,
- *            count: !number}}
+ *            start: number,
+ *            count: number}}
  */
 var CookieRemovePacket;
 
 var categoryLabels = {
   'app_cache': loadTimeData.getString('cookieAppCache'),
   'cache_storage': loadTimeData.getString('cookieCacheStorage'),
   'channel_id': loadTimeData.getString('cookieChannelId'),
   'cookie': loadTimeData.getString('cookieSingular'),
   'database': loadTimeData.getString('cookieDatabaseStorage'),
   'file_system': loadTimeData.getString('cookieFileSystem'),
@@ skipping 45 matching lines @@
      * @param {!Array<!CookieDetails>} newNodes The list containing the data to
      *     add.
      */
     addChildNodes: function(parentNode, newNodes) {
       var nodes = newNodes.map(function(x) {
         return new settings.CookieTreeNode(x);
       });
       parentNode.children_ = nodes;
     },
 
+    /** @return {!CookieDetails} */
+    getCookieDetails: function() {

[Dan Beam, 2016/10/27 21:05:10]

this works, but why not just ... make data_ public as data?

[dschuyler, 2016/10/27 22:54:25]

Done.

+      return this.data_;
+    },
+
     /**
      * Looks up a parent node and adds a list of CookieTreeNodes to them.
      * @param {string} parentId The ID of the parent to add the nodes to.
      * @param {!settings.CookieTreeNode} startingNode The node to start with
      *     when looking for the parent node to add the children to.
      * @param {!Array<!CookieDetails>} newNodes The list containing the data to
          add.
      * @return {boolean} True if the parent node was found.
      */
     populateChildNodes: function(parentId, startingNode, newNodes) {
@@ skipping 102 matching lines @@
         if (this.children_[i].data_.id == id)
           return this.children_[i];
         if (recursive) {
           var node = this.children_[i].fetchNodeById(id, true);
           if (node != null)
             return node;
         }
       }
       return null;
     },
-
-    /**
-     * Get cookie data for a given HTML node.
-     * @return {!Array<CookieDataForDisplay>}
-     */
-    getCookieData: function(item) {
-      /** @type {!Array<CookieDataForDisplay>} */
-      var out = [];
-      var fields = cookieInfo[item.data_.type];
-      for (var field of fields) {
-        // Iterate through the keys found in |cookieInfo| for the given |type|
-        // and see if those keys are present in the data. If so, display them
-        // (in the order determined by |cookieInfo|).
-        var key = field[0];
-        if (item.data_[key].length > 0) {
-          var entry = /** @type {CookieDataForDisplay} */({
-            label: loadTimeData.getString(field[1]),
-            content: item.data_[key],
-          });
-          out.push(entry);
-        }
-      }
-      return out;
-    },
   };
 
   return {
     CookieTreeNode: CookieTreeNode,
   };
 });