third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc - Issue 2451553005: Add NGLogicalOrigin and NGLogicalLeader parameters to NGLayoutOpportunityIterator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

Issue 2451553005: Add NGLogicalOrigin and NGLogicalLeader parameters to NGLayoutOpportunityIterator. (Closed)

Patch Set: do not redefine default LayoutOpportunities parameters Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h ('k') | third_party/WebKit/Source/core/layout/ng/ng_units.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

index 93cf6ed98873a4d2357ffce48ea15f4f011f7567..a44e3a31f08d030640f00604dd390df1ff68a833 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc

@@ -205,9 +205,11 @@ bool CompareNGLayoutOpportunitesByStartPoint(const NGLayoutOpportunity& lhs,

NGLayoutOpportunityIterator::NGLayoutOpportunityIterator(

NGConstraintSpace* space,

- unsigned clear,

- bool for_inline_or_bfc)

- : constraint_space_(space) {

+ const NGLogicalOrigin origin_point,

+ const NGLogicalLeader leader_point)

+ : constraint_space_(space),

+ origin_point_(origin_point),

+ leader_point_(leader_point) {

// TODO(chrome-layout-team): Combine exclusions that shadow each other.

auto exclusions = constraint_space_->PhysicalSpace()->Exclusions();

DCHECK(std::is_sorted(exclusions.begin(), exclusions.end(),