Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc

Issue 2451553005: Add NGLogicalOrigin and NGLogicalLeader parameters to NGLayoutOpportunityIterator. (Closed)
Patch Set: do not redefine default LayoutOpportunities parameters Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
index 2314134dfa10e89dc0a9d6706e004a628888c081..a43f46e402149359aa6448e1b123b0f950564d80 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc
@@ -57,8 +57,7 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesNoExclusions) {
auto* space =
new NGConstraintSpace(HorizontalTopBottom, LeftToRight, physical_space);
- bool for_inline_or_bfc = true;
- auto* iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);
+ auto* iterator = space->LayoutOpportunities();
EXPECT_EQ("0,0 600x400", OpportunityToString(iterator->Next()));
EXPECT_EQ("(empty)", OpportunityToString(iterator->Next()));
@@ -76,8 +75,7 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTopRightExclusion) {
auto* space =
new NGConstraintSpace(HorizontalTopBottom, LeftToRight, physical_space);
- bool for_inline_or_bfc = true;
- auto* iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);
+ auto* iterator = space->LayoutOpportunities();
// First opportunity should be to the left of the exclusion.
EXPECT_EQ("0,0 500x400", OpportunityToString(iterator->Next()));
@@ -101,8 +99,7 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTopLeftExclusion) {
auto* space =
new NGConstraintSpace(HorizontalTopBottom, LeftToRight, physical_space);
- bool for_inline_or_bfc = true;
- auto* iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);
+ auto* iterator = space->LayoutOpportunities();
// First opportunity should be to the right of the exclusion.
EXPECT_EQ("100,0 500x400", OpportunityToString(iterator->Next()));
@@ -151,8 +148,7 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesTwoInMiddle) {
auto* space =
new NGConstraintSpace(HorizontalTopBottom, LeftToRight, physical_space);
- bool for_inline_or_bfc = true;
- auto* iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);
+ auto* iterator = space->LayoutOpportunities();
// 1st Start point
EXPECT_EQ("0,0 600x200", OpportunityToString(iterator->Next()));
@@ -199,8 +195,7 @@ TEST(NGConstraintSpaceTest, LayoutOpportunitiesWithOutOfBoundsExclusions) {
auto* space =
new NGConstraintSpace(HorizontalTopBottom, LeftToRight, physical_space);
- bool for_inline_or_bfc = true;
- auto* iterator = space->LayoutOpportunities(NGClearNone, for_inline_or_bfc);
+ auto* iterator = space->LayoutOpportunities();
EXPECT_EQ("0,0 600x100", OpportunityToString(iterator->Next()));
EXPECT_EQ("(empty)", OpportunityToString(iterator->Next()));

Powered by Google App Engine
This is Rietveld 408576698