Insert logcat as part of test result for android instrumentation tests.

build/android/pylib/instrumentation/instrumentation_test_instance.py

Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index f8d37e76c0223bc5b3f001268120ccd5cbca42e7..70e5ceece411bfbf95083ffd1f1f44471ba06c6a 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -442,6 +442,9 @@ class InstrumentationTestInstance(test_instance.TestInstance):
     self._store_tombstones = False
     self._initializeTombstonesAttributes(args)
 
+    self._json_results_file = None

[jbudorick, 2016/11/29 00:50:59]

self._should_save_logcat

[BigBossZhiling, 2016/11/29 01:38:27]

Done.

+    self._initializeJsonResultsFileAttributes(args)

[jbudorick, 2016/11/29 00:50:59]

nit: this seems overly specific; maybe _initializeResultsAttributes or
_initializeLogAttributes?

[BigBossZhiling, 2016/11/29 01:38:27]

Done.

+
   def _initializeApkAttributes(self, args, error_func):
     if args.apk_under_test:
       apk_under_test_path = args.apk_under_test
@@ -594,6 +597,9 @@ class InstrumentationTestInstance(test_instance.TestInstance):
   def _initializeTombstonesAttributes(self, args):
     self._store_tombstones = args.store_tombstones
 
+  def _initializeJsonResultsFileAttributes(self, args):
+    self._should_save_logcat = bool(args.json_results_file)
+
   @property
   def additional_apks(self):
     return self._additional_apks
@@ -627,6 +633,10 @@ class InstrumentationTestInstance(test_instance.TestInstance):
     return self._flags
 
   @property
+  def should_save_logcat(self):
+    return self._should_save_logcat
+
+  @property
   def package_info(self):
     return self._package_info